8000 bug #21689 [WebServerBundle] fixed html attribute escape (Seb33300) · symfony/symfony@57a81eb · GitHub
[go: up one dir, main page]
Skip to content

Commit 57a81eb

Browse files
javiereguiluzjaviereguiluz
committed
bug #21689 [WebServerBundle] fixed html attribute escape (Seb33300)
This PR was merged into the 2.8 branch. Discussion ---------- [WebServerBundle] fixed html attribute escape | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - In the Web Debug Toolbar, when a toolbar item has extra attributes, they are not properly escaped. (If you put your mouse over the right toolbar item with sf version, you will see a tooltip with `""`) Currently: ```html title="" ``` After: ```html title="" ``` Commits ------- 1337cdb [WebServerBundle] fixed html attribute escape
2 parents de95fd5 + 1337cdb commit 57a81eb

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

‎src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar_item.html.twig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<div class="sf-toolbar-block sf-toolbar-block-{{ name }} sf-toolbar-status-{{ status|default('normal') }} {{ additional_classes|default('') }}" {{ block_attrs|default('') }}>
1+
<div class="sf-toolbar-block sf-toolbar-block-{{ name }} sf-toolbar-status-{{ status|default('normal') }} {{ additional_classes|default('') }}" {{ block_attrs|default('')|raw }}>
22
{% if link is not defined or link %}<a href="{{ path('_profiler', { token: token, panel: name }) }}">{% endif %}
33
<div class="sf-toolbar-icon">{{ icon|default('') }}</div>
44
{% if link is not defined or link %}</a>{% endif %}

0 commit comments

Comments
 (0)
0