minor #45477 [HttpKernel] Remove unused argument in ArgumentMetadataFactory (fancyweb)

nicolas-grekas · nicolas-grekas · commit 57a078b77636 · 2022-02-18T23:02:28.000+01:00
This PR was merged into the 4.4 branch. Discussion ---------- [HttpKernel] Remove unused argument in ArgumentMetadataFactory | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Leftover from #45462, spotted it while trying to merge up. Commits ------- dbe29de [HttpKernel] Remove unused argument in ArgumentMetadataFactory
diff --git a/src/Symfony/Component/HttpKernel/ControllerMetadata/ArgumentMetadataFactory.php b/src/Symfony/Component/HttpKernel/ControllerMetadata/ArgumentMetadataFactory.php
@@ -39,7 +39,7 @@ public function createArgumentMetadata($controller): array
         }
 
         foreach ($reflection->getParameters() as $param) {
-            $arguments[] = new ArgumentMetadata($param->getName(), $this->getType($param, $reflection, $class), $param->isVariadic(), $param->isDefaultValueAvailable(), $param->isDefaultValueAvailable() ? $param->getDefaultValue() : null, $param->allowsNull());
+            $arguments[] = new ArgumentMetadata($param->getName(), $this->getType($param, $class), $param->isVariadic(), $param->isDefaultValueAvailable(), $param->isDefaultValueAvailable() ? $param->getDefaultValue() : null, $param->allowsNull());
         }
 
         return $arguments;
@@ -48,7 +48,7 @@ public function createArgumentMetadata($controller): array
     /**
      * Returns an associated type to the given parameter if available.
      */
-    private function getType(\ReflectionParameter $parameter, \ReflectionFunctionAbstract $function, ?string $class): ?string
+    private function getType(\ReflectionParameter $parameter, ?string $class): ?string
     {
         if (!$type = $parameter->getType()) {
             return null;

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ public function createArgumentMetadata($controller): array`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`foreach ($reflection->getParameters() as $param) {`
`42`		`- $arguments[] = new ArgumentMetadata($param->getName(), $this->getType($param, $reflection, $class), $param->isVariadic(), $param->isDefaultValueAvailable(), $param->isDefaultValueAvailable() ? $param->getDefaultValue() : null, $param->allowsNull());`
	`42`	`+ $arguments[] = new ArgumentMetadata($param->getName(), $this->getType($param, $class), $param->isVariadic(), $param->isDefaultValueAvailable(), $param->isDefaultValueAvailable() ? $param->getDefaultValue() : null, $param->allowsNull());`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`return $arguments;`
`@@ -48,7 +48,7 @@ public function createArgumentMetadata($controller): array`
`48`	`48`	`/**`
`49`	`49`	`* Returns an associated type to the given parameter if available.`
`50`	`50`	`*/`
`51`		`- private function getType(\ReflectionParameter $parameter, \ReflectionFunctionAbstract $function, ?string $class): ?string`
	`51`	`+ private function getType(\ReflectionParameter $parameter, ?string $class): ?string`
`52`	`52`	`{`
`53`	`53`	`if (!$type = $parameter->getType()) {`
`54`	`54`	`return null;`