minor #26091 Update Repository Symlink Helper (zanbaldwin)

nicolas-grekas · nicolas-grekas · commit 573e462b55ee · 2018-02-11T12:15:02.000+01:00
This PR was submitted for the 3.3 branch but it was merged into the 2.7 branch instead (closes #26091). Discussion ---------- Update Repository Symlink Helper The `link` script is super-useful (thanks @dunglas!) for development - but for some it's unusable in its current form due to the use of `GLOB_BRACE` which is [unavailable on certain platforms](zendframework/zend-stdlib#58 (comment)) (such as Alpine) and is a platform-specific problem that will not be fixed in future versions of PHP. I know the code is a little condensed and not the easiest to read, but I thought that wasn't really an issue considering this is just a development helper script and not part of the 'official' Symfony code base. | Q | A | ------------- | --- | Branch? | `3.3` | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | No tests for `/link` | Fixed tickets | | License | MIT | Doc PR | can't find documentation for `/link`  Commits ------- a9568d7 Update Repository Symlink Helper
diff --git a/link b/link
@@ -37,7 +37,12 @@ if (!is_dir("$argv[1]/vendor/symfony")) {
 $sfPackages = array('symfony/symfony' => __DIR__);
 
 $filesystem = new Filesystem();
-foreach (glob(__DIR__.'/src/Symfony/{Bundle,Bridge,Component,Component/Security}/*', GLOB_BRACE | GLOB_ONLYDIR | GLOB_NOSORT) as $dir) {
+$braces = array('Bundle', 'Bridge', 'Component', 'Component/Security');
+$directories = call_user_func_array('array_merge', array_values(array_map(function ($part) {
+    return glob(__DIR__.'/src/Symfony/'.$part.'/*', GLOB_ONLYDIR | GLOB_NOSORT);
+}, $braces)));
+
+foreach ($directories as $dir) {
     if ($filesystem->exists($composer = "$dir/composer.json")) {
         $sfPackages[json_decode(file_get_contents($composer))->name] = $dir;
     }
