[VarDumper] fix infinite recursion

nicolas-grekas · nicolas-grekas · commit 56d9f4785729 · 2019-10-26T10:24:21.000+02:00
diff --git a/src/Symfony/Component/VarDumper/Caster/ClassStub.php b/src/Symfony/Component/VarDumper/Caster/ClassStub.php
@@ -62,7 +62,7 @@ public function __construct(string $identifier, $callable = null)
             }
 
             if (null !== $callable && $r instanceof \ReflectionFunctionAbstract) {
-                $s = ReflectionCaster::castFunctionAbstract($r, [], new Stub(), true);
+                $s = ReflectionCaster::castFunctionAbstract($r, [], new Stub(), true, Caster::EXCLUDE_VERBOSE);
                 $s = ReflectionCaster::getSignature($s);
 
                 if ('()' === substr($identifier, -2)) {
diff --git a/src/Symfony/Component/VarDumper/Caster/ReflectionCaster.php b/src/Symfony/Component/VarDumper/Caster/ReflectionCaster.php
@@ -212,7 +212,7 @@ public static function castFunctionAbstract(\ReflectionFunctionAbstract $c, arra
             $a[$prefix.'parameters'] = new EnumStub($a[$prefix.'parameters']);
         }
 
-        if ($v = $c->getStaticVariables()) {
+        if (!($filter & Caster::EXCLUDE_VERBOSE) && $v = $c->getStaticVariables()) {
             foreach ($v as $k => &$v) {
                 if (\is_object($v)) {
                     $a[$prefix.'use']['$'.$k] = new CutStub($v);

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ public function __construct(string $identifier, $callable = null)`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`if (null !== $callable && $r instanceof \ReflectionFunctionAbstract) {`
`65`		`- $s = ReflectionCaster::castFunctionAbstract($r, [], new Stub(), true);`
	`65`	`+ $s = ReflectionCaster::castFunctionAbstract($r, [], new Stub(), true, Caster::EXCLUDE_VERBOSE);`
`66`	`66`	`$s = ReflectionCaster::getSignature($s);`
`67`	`67`
`68`	`68`	`if ('()' === substr($identifier, -2)) {`
Original file line number	Diff line number	Diff line change
`@@ -212,7 +212,7 @@ public static function castFunctionAbstract(\ReflectionFunctionAbstract $c, arra`
`212`	`212`	`$a[$prefix.'parameters'] = new EnumStub($a[$prefix.'parameters']);`
`213`	`213`	`}`
`214`	`214`
`215`		`- if ($v = $c->getStaticVariables()) {`
	`215`	`+ if (!($filter & Caster::EXCLUDE_VERBOSE) && $v = $c->getStaticVariables()) {`
`216`	`216`	`foreach ($v as $k => &$v) {`
`217`	`217`	`if (\is_object($v)) {`
`218`	`218`	`$a[$prefix.'use']['$'.$k] = new CutStub($v);`