fix test setup and skip test until bug is fixed in PHP

xabbuh · xabbuh · commit 56bd932ba8ef · 2025-03-02T16:14:39.000+01:00
diff --git a/src/Symfony/Component/Validator/Tests/Constraints/Fixtures/WhenTestWithClosure.php b/src/Symfony/Component/Validator/Tests/Constraints/Fixtures/WhenTestWithClosure.php
@@ -11,13 +11,14 @@
 
 namespace Symfony\Component\Validator\Tests\Constraints\Fixtures;
 
+use Symfony\Component\Validator\Constraints\Callback;
 use Symfony\Component\Validator\Constraints\NotBlank;
 use Symfony\Component\Validator\Constraints\NotNull;
 use Symfony\Component\Validator\Constraints\When;
 
 #[When(expression: static function () {
         return true;
-    }, constraints: new NotNull()
+    }, constraints: new Callback('isValid')
 )]
 class WhenTestWithClosure
 {
diff --git a/src/Symfony/Component/Validator/Tests/Constraints/WhenTest.php b/src/Symfony/Component/Validator/Tests/Constraints/WhenTest.php
@@ -118,6 +118,8 @@ public function testAttributes()
      */
     public function testAttributesWithClosure()
     {
+        $this->markTestSkipped('Requires https://github.com/php/php-src/issues/17851 to be fixed');
+
         $loader = new AttributeLoader();
         $metadata = new ClassMetadata(WhenTestWithClosure::class);
 
@@ -129,7 +131,7 @@ public function testAttributesWithClosure()
         self::assertInstanceOf(\Closure::class, $classConstraint->expression);
         self::assertEquals([
             new Callback(
-                callback: 'callback',
+                callback: 'isValid',
                 groups: ['Default', 'WhenTestWithClosure'],
             ),
         ], $classConstraint->constraints);
