8000 Merge branch '6.4' into 7.2 · symfony/symfony@56820ed · GitHub
[go: up one dir, main page]

Skip to content

Commit 56820ed

Browse files
committed
Merge branch '6.4' into 7.2
* 6.4: skip failing Semaphore component tests on GitHub Actions with PHP 8.5 Update GetSetMethodNormalizer.php [Stopwatch] Fix StopWatchEvent never throws InvalidArgumentException
2 parents 0f6fd37 + 7c515b2 commit 56820ed

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

src/Symfony/Component/Semaphore/Tests/Store/RelayStoreTest.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,10 @@ protected function setUp(): void
2525

2626
public static function setUpBeforeClass(): void
2727
{
28+
if (\PHP_VERSION_ID <= 80500 && isset($_SERVER['GITHUB_ACTIONS'])) {
29+
self::markTestSkipped('Test segfaults on PHP 8.5');
30+
}
31+
2832
try {
2933
new Relay(...explode(':', getenv('REDIS_HOST')));
3034
} catch (\Relay\Exception $e) {

src/Symfony/Component/Serializer/Normalizer/GetSetMethodNormalizer.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ private function isSetMethod(\ReflectionMethod $method): bool
100100
return !$method->isStatic()
101101
&& !$method->getAttributes(Ignore::class)
102102
&& 0 < $method->getNumberOfParameters()
103+
&& 3 < \strlen($method->name)
103104
&& str_starts_with($method->name, 'set')
104105
&& !ctype_lower($method->name[3])
105106
;

src/Symfony/Component/Stopwatch/StopwatchEvent.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,6 @@ class StopwatchEvent
3838
* @param string|null $category The event category or null to use the default
3939
* @param bool $morePrecision If true, time is stored as float to keep the original microsecond precision
4040
* @param string|null $name The event name or null to define the name as default
41-
*
42-
* @throws \InvalidArgumentException When the raw time is not valid
4341
*/
4442
public function __construct(
4543
float $origin,
@@ -219,8 +217,6 @@ protected function getNow(): float
219217

220218
/**
221219
* Formats a time.
222-
*
223-
* @throws \InvalidArgumentException When the raw time is not valid
224220
*/
225221
private function formatTime(float $time): float
226222
{

0 commit comments

Comments
 (0)
0