deprecate the testLegacy test name prefix

xabbuh · xabbuh · commit 550e86bb52ab · 2017-01-02T19:23:29.000+01:00
diff --git a/src/Symfony/Bridge/PhpUnit/SymfonyTestsListener.php b/src/Symfony/Bridge/PhpUnit/SymfonyTestsListener.php
@@ -197,6 +197,11 @@ public function endTest(\PHPUnit_Framework_Test $test, $time)
                 DnsMock::withMockedHosts(array());
             }
         }
+
+        if ($test instanceof \PHPUnit_Framework_TestCase && 0 === strpos($test->getName(), 'testLegacy') && empty($test->getTestResultObject()->warningCount())) {
+            $result = $test->getTestResultObject();
+            $result->addWarning($test, new \PHPUnit_Framework_Warning('Using the testLegacy prefix to mark tests as legacy is deprecated since version 3.3 and will be removed in 4.0. Use the "@group legacy" notation instead to add the test to the legacy group.'), $time);
+        }
     }
 
     public function handleError($type, $msg, $file, $line, $context)

Original file line number	Diff line number	Diff line change
`@@ -197,6 +197,11 @@ public function endTest(\PHPUnit_Framework_Test $test, $time)`
`197`	`197`	`DnsMock::withMockedHosts(array());`
`198`	`198`	`}`
`199`	`199`	`}`
	`200`	`+`
	`201`	`+ if ($test instanceof \PHPUnit_Framework_TestCase && 0 === strpos($test->getName(), 'testLegacy') && empty($test->getTestResultObject()->warningCount())) {`
	`202`	`+ $result = $test->getTestResultObject();`
	`203`	`+ $result->addWarning($test, new \PHPUnit_Framework_Warning('Using the testLegacy prefix to mark tests as legacy is deprecated since version 3.3 and will be removed in 4.0. Use the "@group legacy" notation instead to add the test to the legacy group.'), $time);`
	`204`	`+ }`
`200`	`205`	`}`
`201`	`206`
`202`	`207`	`public function handleError($type, $msg, $file, $line, $context)`