changed setOptions() and __destruct()

andrei0x309 · andrei0x309 · commit 54751dbd08d6 · 2020-09-08T13:59:49.000+03:00
diff --git a/src/Symfony/Component/Process/Process.php b/src/Symfony/Component/Process/Process.php
@@ -197,7 +197,7 @@ public static function fromShellCommandline(string $command, string $cwd = null,
 
     public function __destruct()
     {
-        if (!$this->options['create_new_console']) {
+        if (!($this->options['detach'] ?? $this->options['create_new_console'])) {
             $this->stop(0);
         } else {
             $this->processPipes->close();
@@ -1228,24 +1228,24 @@ public function getStartTime(): float
      * detach option can be used to run a process in the background
      * using detach you can can finish execution before the process has finished working
      * use setOptions(['detach' => true]) before using start
+     * on Win you need both detach => true, and create_new_console => true, to start a bacground process and exit your main script without waiting for the process to finish
      * detach requires minimum PHP 7.4.4.
      */
     public function setOptions(array $options)
     {
+        if ($this->isRunning()) {
+            throw new RuntimeException('Setting options while the process is running is not possible.');
+        }
+
         $defaultOptions = $this->options;
-        $existingWinOptions = ['blocking_pipes', 'create_process_group', 'detach'];
+        $existingOptions = ['blocking_pipes', 'create_process_group', 'detach', 'create_new_console'];
 
         foreach ($options as $key => $value) {
-            if (!\in_array($key, $existingWinOptions)) {
+            if (!\in_array($key, $existingOptions)) {
                 $this->options = $defaultOptions;
                 throw new LogicException(sprintf('Invalid option "%s" passed to "%s()". Supported options are "%s".', $key, __METHOD__, implode('", "', $existingOptions)));
             }
-
-            if ('detach' === $key) {
-                $this->options['create_new_console'] = $value;
-            } else {
-                $this->options[$key] = $value;
-            }
+            $this->options[$key] = $value;
         }
     }
 
