Edit comments

dunglas · dunglas · commit 5470db26b622 · 2016-04-18T20:58:35.000+02:00
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php b/src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php
@@ -174,6 +174,7 @@ private function autowireMethod($id, Definition $definition, \ReflectionMethod $
                         } elseif ($parameter->isDefaultValueAvailable()) {
                             $value = $parameter->getDefaultValue();
                         } else {
+                            // The exception code is set to 1 if the exception must be thrown even if it's a setter
                             if (1 === $e->getCode() || $isConstructor) {
                                 throw $e;
                             }
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php b/src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php
@@ -727,7 +727,6 @@ public function setBar()
     public function setNotAutowireable(NotARealClass $n)
     {
         // should not be called
-        // ???
     }
 
     public function setArgCannotAutowire($foo)

Original file line number	Diff line number	Diff line change
`@@ -174,6 +174,7 @@ private function autowireMethod($id, Definition $definition, \ReflectionMethod $`
`174`	`174`	`} elseif ($parameter->isDefaultValueAvailable()) {`
`175`	`175`	`$value = $parameter->getDefaultValue();`
`176`	`176`	`} else {`
	`177`	`+ // The exception code is set to 1 if the exception must be thrown even if it's a setter`
`177`	`178`	`if (1 === $e->getCode() \|\| $isConstructor) {`
`178`	`179`	`throw $e;`
`179`	`180`	`}`
Original file line number	Diff line number	Diff line change
`@@ -727,7 +727,6 @@ public function setBar()`
`727`	`727`	`public function setNotAutowireable(NotARealClass $n)`
`728`	`728`	`{`
`729`	`729`	`// should not be called`
`730`		`- // ???`
`731`	`730`	`}`
`732`	`731`
`733`	`732`	`public function setArgCannotAutowire($foo)`