feature #28277 [Serializer] AbstractObjectNormalizer improve performance (martiis)

fabpot · fabpot · commit 53ffa6674a0f · 2018-08-27T17:56:01.000+02:00
This PR was merged into the 4.2-dev branch. Discussion ---------- [Serializer] AbstractObjectNormalizer improve performance | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28276 | License | MIT Check ticket for description Commits ------- 4224145 [Serializer] AbstractObjectNormalizer improve perf when checking types
diff --git a/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
@@ -37,6 +37,7 @@ abstract class AbstractObjectNormalizer extends AbstractNormalizer
     const DISABLE_TYPE_ENFORCEMENT = 'disable_type_enforcement';
 
     private $propertyTypeExtractor;
+    private $typesCache = array();
     private $attributesCache = array();
 
     /**
@@ -366,24 +367,31 @@ private function getTypes(string $currentClass, string $attribute)
             return null;
         }
 
+        $key = $currentClass.'::'.$attribute;
+        if (isset($this->typesCache[$key])) {
+            return false === $this->typesCache[$key] ? null : $this->typesCache[$key];
+        }
+
         if (null !== $types = $this->propertyTypeExtractor->getTypes($currentClass, $attribute)) {
-            return $types;
+            return $this->typesCache[$key] = $types;
         }
 
         if (null !== $this->classDiscriminatorResolver && null !== $discriminatorMapping = $this->classDiscriminatorResolver->getMappingForClass($currentClass)) {
             if ($discriminatorMapping->getTypeProperty() === $attribute) {
-                return array(
+                return $this->typesCache[$key] = array(
                     new Type(Type::BUILTIN_TYPE_STRING),
                 );
             }
 
             foreach ($discriminatorMapping->getTypesMapping() as $mappedClass) {
                 if (null !== $types = $this->propertyTypeExtractor->getTypes($mappedClass, $attribute)) {
-                    return $types;
+                    return $this->typesCache[$key] = $types;
                 }
             }
         }
 
+        $this->typesCache[$key] = false;
+
         return null;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,7 @@ abstract class AbstractObjectNormalizer extends AbstractNormalizer`
`37`	`37`	`const DISABLE_TYPE_ENFORCEMENT = 'disable_type_enforcement';`
`38`	`38`
`39`	`39`	`private $propertyTypeExtractor;`
	`40`	`+ private $typesCache = array();`
`40`	`41`	`private $attributesCache = array();`
`41`	`42`
`42`	`43`	`/**`
`@@ -366,24 +367,31 @@ private function getTypes(string $currentClass, string $attribute)`
`366`	`367`	`return null;`
`367`	`368`	`}`
`368`	`369`
	`370`	`+ $key = $currentClass.'::'.$attribute;`
	`371`	`+ if (isset($this->typesCache[$key])) {`
	`372`	`+ return false === D70C $this->typesCache[$key] ? null : $this->typesCache[$key];`
	`373`	`+ }`
	`374`	`+`
`369`	`375`	`if (null !== $types = $this->propertyTypeExtractor->getTypes($currentClass, $attribute)) {`
`370`		`- return $types;`
	`376`	`+ return $this->typesCache[$key] = $types;`
`371`	`377`	`}`
`372`	`378`
`373`	`379`	`if (null !== $this->classDiscriminatorResolver && null !== $discriminatorMapping = $this->classDiscriminatorResolver->getMappingForClass($currentClass)) {`
`374`	`380`	`if ($discriminatorMapping->getTypeProperty() === $attribute) {`
`375`		`- return array(`
	`381`	`+ return $this->typesCache[$key] = array(`
`376`	`382`	`new Type(Type::BUILTIN_TYPE_STRING),`
`377`	`383`	`);`
`378`	`384`	`}`
`379`	`385`
`380`	`386`	`foreach ($discriminatorMapping->getTypesMapping() as $mappedClass) {`
`381`	`387`	`if (null !== $types = $this->propertyTypeExtractor->getTypes($mappedClass, $attribute)) {`
`382`		`- return $types;`
	`388`	`+ return $this->typesCache[$key] = $types;`
`383`	`389`	`}`
`384`	`390`	`}`
`385`	`391`	`}`
`386`	`392`
	`393`	`+ $this->typesCache[$key] = false;`
	`394`	`+`
`387`	`395`	`return null;`
`388`	`396`	`}`
`389`	`397`