fix handling float-like key attribute values

xabbuh · xabbuh · commit 53d286a0193e · 2021-01-08T10:30:08.000+01:00
diff --git a/src/Symfony/Component/Config/Definition/PrototypedArrayNode.php b/src/Symfony/Component/Config/Definition/PrototypedArrayNode.php
@@ -237,6 +237,10 @@ protected function normalizeValue($value)
                 } elseif (isset($v[$this->keyAttribute])) {
                     $k = $v[$this->keyAttribute];
 
+                    if (!is_int($k) && !\is_string($k)) {
+                        $k = var_export($k, true);
+                    }
+
                     // remove the key attribute when required
                     if ($this->removeKeyAttribute) {
                         unset($v[$this->keyAttribute]);
diff --git a/src/Symfony/Component/Config/Tests/Definition/NormalizationTest.php b/src/Symfony/Component/Config/Tests/Definition/NormalizationTest.php
@@ -201,6 +201,42 @@ public function testAssociativeArrayPreserveKeys()
         $this->assertNormalized($tree, $data, $data);
     }
 
+    public function testFloatLikeValueAsMapKeyAttribute()
+    {
+        $tree = (new TreeBuilder('root'))
+            ->getRootNode()
+                ->useAttributeAsKey('number')
+                ->arrayPrototype()
+                    ->children()
+                        ->scalarNode('foo')->end()
+                    ->end()
+                ->end()
+            ->end()
+            ->buildTree()
+        ;
+
+        $config = [
+            [
+                'number' => 3.0,
+                'foo' => 'bar',
+            ],
+        ];
+        $normalized = [
+            '3.0' => [
+                'foo' => 'bar',
+            ],
+        ];
+
+        $this->assertNormalized($tree, $config, $normalized);
+    }
+
+    public function provideKeyAttributeValue(): array
+    {
+        return [
+            [2.0],
+        ];
+    }
+
     public static function assertNormalized(NodeInterface $tree, $denormalized, $normalized)
     {
         self::assertSame($normalized, $tree->normalize($denormalized));
