Optimize assertLocale regexp

Jérémy Derussé · Jérémy Derussé · commit 537c39b11ec8 · 2014-07-22T23:54:07.000+02:00
diff --git a/src/Symfony/Component/Translation/Translator.php b/src/Symfony/Component/Translation/Translator.php
@@ -308,7 +308,7 @@ protected function computeFallbackLocales($locale)
      */
     private function assertValidLocale($locale)
     {
-        if (0 !== preg_match('/[^a-z0-9@_\\.\\-]+/i', $locale, $match)) {
+        if (1 !== preg_match('/^[a-z0-9@_\\.\\-]*$/i', $locale)) {
             throw new \InvalidArgumentException(sprintf('Invalid locale: %s.', $locale));
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -308,7 +308,7 @@ protected function computeFallbackLocales($locale)`
`308`	`308`	`*/`
`309`	`309`	`private function assertValidLocale($locale)`
`310`	`310`	`{`
`311`		`- if (0 !== preg_match('/[^a-z0-9@_\\.\\-]+/i', $locale, $match)) {`
	`311`	`+ if (1 !== preg_match('/^[a-z0-9@_\\.\\-]*$/i', $locale)) {`
`312`	`312`	`throw new \InvalidArgumentException(sprintf('Invalid locale: %s.', $locale));`
`313`	`313`	`}`
`314`	`314`	`}`