Fixed templateExists on parse error of the template name

yceruto · yceruto · commit 53347c42fde8 · 2018-07-19T14:17:34.000-04:00
diff --git a/src/Symfony/Component/HttpKernel/Fragment/HIncludeFragmentRenderer.php b/src/Symfony/Component/HttpKernel/Fragment/HIncludeFragmentRenderer.php
@@ -135,7 +135,7 @@ private function templateExists($template)
         if ($this->templating instanceof EngineInterface) {
             try {
                 return $this->templating->exists($template);
-            } catch (\InvalidArgumentException $e) {
+            } catch (\Exception $e) {
                 return false;
             }
         }
diff --git a/src/Symfony/Component/HttpKernel/Tests/Fragment/HIncludeFragmentRendererTest.php b/src/Symfony/Component/HttpKernel/Tests/Fragment/HIncludeFragmentRendererTest.php
@@ -86,4 +86,17 @@ public function testRenderWithDefaultText()
         $strategy = new HIncludeFragmentRenderer($engine);
         $this->assertEquals('<hx:include src="/foo">default</hx:include>', $strategy->render('/foo', Request::create('/'), array('default' => 'default'))->getContent());
     }
+
+    public function testRenderWithEngineAndDefaultText()
+    {
+        $engine = $this->getMockBuilder('Symfony\\Component\\Templating\\EngineInterface')->getMock();
+        $engine->expects($this->once())
+            ->method('exists')
+            ->with('loading...')
+            ->will($this->throwException(new \RuntimeException()));
+
+        // only default
+        $strategy = new HIncludeFragmentRenderer($engine);
+        $this->assertEquals('<hx:include src="/foo">loading...</hx:include>', $strategy->render('/foo', Request::create('/'), array('default' => 'loading...'))->getContent());
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ private function templateExists($template)`
`135`	`135`	`if ($this->templating instanceof EngineInterface) {`
`136`	`136`	`try {`
`137`	`137`	`return $this->templating->exists($template);`
`138`		`- } catch (\InvalidArgumentException $e) {`
	`138`	`+ } catch (\Exception $e) {`
`139`	`139`	`return false;`
`140`	`140`	`}`
`141`	`141`	`}`