10000 Clone messages to show in profiler · symfony/symfony@52f4da9 · GitHub
[go: up one dir, main page]
Skip to content

Commit 52f4da9

Browse files
NyholmNyholm
committed
Clone messages to show in profiler
1 parent 4bbdf06 commit 52f4da9

File tree

2 files changed

+23
-7
lines changed

2 files changed

+23
-7
lines changed

‎src/Symfony/Bundle/FrameworkBundle/DataCollector/MessengerDataCollector.php

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ public function handle($message, callable $next)
5353
$debugRepresentation = array(
5454
'message' => array(
5555
'type' => get_class($message),
56+
'object' => $this->cloneVar($message),
5657
),
5758
);
5859

@@ -63,6 +64,12 @@ public function handle($message, callable $next)
6364
if (is_object($result)) {
6465
$debugRepresentation['result'] = array(
6566
'type' => get_class($result),
67+
'object' => $this->cloneVar($result),
68+
);
69+
} elseif (is_array($result)) {
70+
$debugRepresentation['result'] = array(
71+
'type' => 'array',
72+
'object' => $this->cloneVar($result),
6673
);
6774
} else {
6875
$debugRepresentation['result'] = array(
@@ -77,7 +84,7 @@ public function handle($message, callable $next)
7784
);
7885
}
7986

80-
$this->data[] = $debugRepresentation;
87+
$this->data['messages'][] = $debugRepresentation;
8188

8289
if (null !== $exception) {
8390
throw $exception;
@@ -88,6 +95,6 @@ public function handle($message, callable $next)
8895

8996
public function getMessages(): array
9097
{
91-
return $this->data;
98+
return $this->data['messages'];
9299
}
93100
}

‎src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/messages.html.twig

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,22 @@
3131
<tbody>
3232
{% for message in collector.messages %}
3333
<tr>
34-
<td>{{ message.message.type }}</td>
3534
<td>
36-
{% if message.result.type is defined %}
35+
{% if message.result.object is defined %}
36+
{{ profiler_dump(message.message.object, maxDepth=2) }}
37+
{% else %}
38+
{{ message.message.type }}
39+
{% endif %}
40+
</td>
41+
<td>
42+
{% if message.result.object is defined %}
43+
{{ profiler_dump(message.result.object, maxDepth=2) }}
44+
{% elseif message.result.type is defined %}
3745
{{ message.result.type }}
46+
{% if message.result.value is defined %}
47+
{{ message.result.value }}
48+
{% endif %}
3849
{% endif %}
39-
4050
{% if message.exception.type is defined %}
4151
{{ message.exception.type }}
4252
{% endif %}
@@ -50,10 +60,9 @@
5060

5161
{% block toolbar %}
5262
{% set color_code = 'normal' %}
53-
{% set message_count = 0 %}
5463
{% set icon %}
5564
{{ include('@WebProfiler/Icon/messages.svg') }}
56-
<span class="sf-toolbar-value">{{ message_count }}</span>
65+
<span class="sf-toolbar-value">{{ collector.messages|length }}</span>
5766
{% endset %}
5867

5968
{{ include('@WebProfiler/Profiler/toolbar_item.html.twig', { link: 'messages', status: color_code }) }}

0 commit comments

Comments
 (0)
0