minor #58241 [HttpKernel] allow narrow type of not nullable getResponse when hasResponse has been called (shyim)

nicolas-grekas · nicolas-grekas · commit 52f1436b5c58 · 2024-10-09T17:02:48.000+02:00
This PR was submitted for the 5.4 branch but it was squashed and merged into the 7.2 branch instead. Discussion ---------- [HttpKernel] allow narrow type of not nullable getResponse when hasResponse has been called | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT ```php if ($event->hasResponse()) { return $event->getResponse(); } ``` PHPStan understands now inside the if that Response is not nullable anymore Commits ------- 69f2f48 [HttpKernel] allow narrow type of not nullable getResponse when hasResponse has been called
diff --git a/src/Symfony/Component/HttpKernel/Event/RequestEvent.php b/src/Symfony/Component/HttpKernel/Event/RequestEvent.php
@@ -46,6 +46,8 @@ public function setResponse(Response $response): void
 
     /**
      * Returns whether a response was set.
+     *
+     * @psalm-assert-if-true !null $this->getResponse()
      */
     public function hasResponse(): bool
     {

Original file line number	Diff line number	Diff line change
`@@ -46,6 +46,8 @@ public function setResponse(Response $response): void`
`46`	`46`
`47`	`47`	`/**`
`48`	`48`	`* Returns whether a response was set.`
	`49`	`+ *`
	`50`	`+ * @psalm-assert-if-true !null $this->getResponse()`
`49`	`51`	`*/`
`50`	`52`	`public function hasResponse(): bool`
`51`	`53`	`{`