8000 minor #44088 [ExpressionLanguage] Fix LexerTest number types (fancyweb) · symfony/symfony@52d0a50 · GitHub
[go: up one dir, main page]
Skip to content

Commit 52d0a50

Browse files
fabpotfabpot
committed
minor #44088 [ExpressionLanguage] Fix LexerTest number types (fancyweb)
This PR was merged into the 4.4 branch. Discussion ---------- [ExpressionLanguage] Fix LexerTest number types | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | #44073 (comment) | License | MIT | Doc PR | - Very minor but it's better like this. Commits ------- bdf9adc [ExpressionLanguage] Fix LexerTest number types
2 parents d3e3815 + bdf9adc commit 52d0a50

File tree

2 files changed

+17
-5
lines changed

2 files changed

+17
-5
lines changed

‎src/Symfony/Component/ExpressionLanguage/Tests/LexerTest.php

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ public function getTokenizeData()
7070
'"foo"',
7171
],
7272
[
73-
[new Token('number', '3', 1)],
73+
[new Token('number', 3, 1)],
7474
'3',
7575
],
7676
[
@@ -84,9 +84,9 @@ public function getTokenizeData()
8484
[
8585
[
8686
new Token('punctuation', '(', 1),
87-
new Token('number', '3', 2),
87+
new Token('number', 3, 2),
8888
new Token('operator', '+', 4),
89-
new Token('number', '5', 6),
89+
new Token('number', 5, 6),
9090
new Token('punctuation', ')', 7),
9191
new Token('operator', '~', 9),
9292
new Token('name', 'foo', 11),
@@ -96,17 +96,25 @@ public function getTokenizeData()
9696
new Token('punctuation', '.', 21),
9797
new Token('name', 'baz', 22),
9898
new Token('punctuation', '[', 25),
99-
new Token('number', '4', 26),
99+
new Token('number', 4, 26),
100100
new Token('punctuation', ']', 27),
101101
new Token('operator', '-', 29),
102-
new Token('number', '1990', 31),
102+
new Token('number', 1990, 31),
103103
],
104104
'(3 + 5) ~ foo("bar").baz[4] - 1.99E+3',
105105
],
106106
[
107107
[new Token('operator', '..', 1)],
108108
'..',
109109
],
110+
[
111+
[
112+
new Token('number', 23, 1),
113+
new Token('operator', '..', 3),
114+
new Token('number', 26, 5),
115+
],
116+
'23..26',
117+
],
110118
[
111119
[new Token('string', '#foo', 1)],
112120
"'#foo'",

‎src/Symfony/Component/ExpressionLanguage/Tests/ParserTest.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,10 @@ public function getParseData()
185185
'not foo or foo.not',
186186
['foo'],
187187
],
188+
[
189+
new Node\BinaryNode('..', new Node\ConstantNode(0), new Node\ConstantNode(3)),
190+
'0..3',
191+
],
188192
];
189193
}
190194

0 commit comments

Comments
 (0)
0