minor #52959 [String] Skip a test when an issue is detected in PCRE2 (alexandre-daubois)

fabpot · fabpot · commit 52839bef6f38 · 2023-12-09T17:12:58.000+01:00
This PR was merged into the 5.4 branch. Discussion ---------- [String] Skip a test when an issue is detected in PCRE2 | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Part of #52206 | License | MIT I propose to ignore this test when [this issue of PCRE2](PCRE2Project/pcre2#361) is detected until it's resolved and the polyfill updated. Commits ------- bf66274 [String] Skip a test when an issue is detected in PCRE2
diff --git a/src/Symfony/Component/String/Tests/AbstractUnicodeTestCase.php b/src/Symfony/Component/String/Tests/AbstractUnicodeTestCase.php
@@ -94,14 +94,21 @@ public function testCodePointsAt(array $expected, string $string, int $offset, i
 
     public static function provideCodePointsAt(): array
     {
-        return [
+        $data = [
             [[], '', 0],
             [[], 'a', 1],
             [[0x53], 'Späßchen', 0],
             [[0xE4], 'Späßchen', 2],
             [[0xDF], 'Späßchen', -5],
-            [[0x260E], '☢☎❄', 1],
         ];
+
+        // Skip this set if we encounter an issue in PCRE2
+        // @see https://github.com/PCRE2Project/pcre2/issues/361
+        if (3 === grapheme_strlen('☢☎❄')) {
+            $data[] = [[0x260E], '☢☎❄', 1];
+        }
+
+        return $data;
     }
 
     public static function provideLength(): array
