bug #30509 [Form] Fix debug form when using partial type name (yceruto)

nicolas-grekas · nicolas-grekas · commit 5218979a763d · 2019-03-13T16:58:09.000+01:00
This PR was merged into the 4.3-dev branch. Discussion ---------- [Form] Fix debug form when using partial type name | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT Since #29452 (4.3) we have the possibility of passing a partial type name. This fixes the case where `debug:form dateTime` doesn't work as expected: ```bash In FormRegistry.php line 89: [Symfony\Component\Form\Exception\InvalidArgumentException] Could not load type "dateTime": class does not implement "Symfony\Component\Form\FormTypeInterface". ``` Commits ------- 22b20ca Fix debug:form dateTime
diff --git a/src/Symfony/Component/Form/Command/DebugCommand.php b/src/Symfony/Component/Form/Command/DebugCommand.php
@@ -115,7 +115,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
                 sort($options[$k]);
             }
         } else {
-            if (!class_exists($class)) {
+            if (!class_exists($class) || !is_subclass_of($class, FormTypeInterface::class)) {
                 $class = $this->getFqcnTypeClass($input, $io, $class);
             }
             $resolvedType = $this->formRegistry->getType($class);
diff --git a/src/Symfony/Component/Form/Tests/Command/DebugCommandTest.php b/src/Symfony/Component/Form/Tests/Command/DebugCommandTest.php
@@ -66,6 +66,15 @@ public function testDebugSingleFormType()
         $this->assertContains('Symfony\Component\Form\Extension\Core\Type\FormType (Block prefix: "form")', $tester->getDisplay());
     }
 
+    public function testDebugDateTimeType()
+    {
+        $tester = $this->createCommandTester();
+        $tester->execute(['class' => 'DateTime'], ['decorated' => false, 'interactive' => false]);
+
+        $this->assertEquals(0, $tester->getStatusCode(), 'Returns 0 in case of success');
+        $this->assertContains('Symfony\Component\Form\Extension\Core\Type\DateTimeType (Block prefix: "datetime")', $tester->getDisplay());
+    }
+
     public function testDebugFormTypeOption()
     {
         $tester = $this->createCommandTester();

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,7 @@ protected function execute(InputInterface $input, OutputInterface $output)`
`115`	`115`	`sort($options[$k]);`
`116`	`116`	`}`
`117`	`117`	`} else {`
`118`		`- if (!class_exists($class)) {`
	`118`	`+ if (!class_exists($class) \|\| !is_subclass_of($class, FormTypeInterface::class)) {`
`119`	`119`	`$class = $this->getFqcnTypeClass($input, $io, $class);`
`120`	`120`	`}`
`121`	`121`	`$resolvedType = $this->formRegistry->getType($class);`