[FrameworkBundle] Dont store cache misses on warmup

Nyholm · Nyholm · commit 512e88932795 · 2021-03-30T23:51:46.000+02:00
diff --git a/src/Symfony/Bundle/FrameworkBundle/CacheWarmer/AbstractPhpFileCacheWarmer.php b/src/Symfony/Bundle/FrameworkBundle/CacheWarmer/AbstractPhpFileCacheWarmer.php
@@ -58,6 +58,9 @@ public function warmUp($cacheDir)
         // so here we un-serialize the values first
         $values = array_map(function ($val) { return null !== $val ? unserialize($val) : null; }, $arrayAdapter->getValues());
 
+        // Remove null values (cache misses)
+        $values = array_filter($values);
+
         $this->warmUpPhpArrayAdapter(new PhpArrayAdapter($this->phpArrayFile, new NullAdapter()), $values);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -58,6 +58,9 @@ public function warmUp($cacheDir)`
`58`	`58`	`// so here we un-serialize the values first`
`59`	`59`	`$values = array_map(function ($val) { return null !== $val ? unserialize($val) : null; }, $arrayAdapter->getValues());`
`60`	`60`
	`61`	`+ // Remove null values (cache misses)`
	`62`	`+ $values = array_filter($values);`
	`63`	`+`
`61`	`64`	`$this->warmUpPhpArrayAdapter(new PhpArrayAdapter($this->phpArrayFile, new NullAdapter()), $values);`
`62`	`65`	`}`
`63`	`66`