bug #46121 Fix "Notice: Undefined index: headers" in messenger with Oracle (rjd22)

nicolas-grekas · nicolas-grekas · commit 511684603c1c · 2022-04-20T15:39:20.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- Fix "Notice: Undefined index: headers" in messenger with Oracle | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | no | License | MIT | Doc PR | no When using messenger with Oracle. The following exception happens: ``` In Connection.php line 453: [ErrorException] Notice: Undefined index: headers Exception trace: at /var/www/epmmusic/vendor/symfony/doctrine-messenger/Transport/Connection.php:453 Symfony\Component\Messenger\Bridge\Doctrine\Transport\Connection->decodeEnvelopeHeaders() ``` The reason for this exception is because most Oracle databases use all caps table and field names. This is not a problem for updating and saving but when messenger tries to get the messages it will result in a response with all caps field names. By selecting the was we do `SELECT table.foo as "foo"` we force the result to be lowercase even when the actual field is all caps. Commits ------- 3ae3e5a Fix "Notice: Undefined index: headers" in messenger with Oracle
diff --git a/src/Symfony/Component/Messenger/Tests/Transport/Doctrine/ConnectionTest.php b/src/Symfony/Component/Messenger/Tests/Transport/Doctrine/ConnectionTest.php
@@ -409,7 +409,7 @@ public function providePlatformSql(): iterable
 
         yield 'Oracle' => [
             new OraclePlatform(),
-            'SELECT w.* FROM messenger_messages w WHERE w.id IN(SELECT a.id FROM (SELECT m.* FROM messenger_messages m WHERE (m.delivered_at is null OR m.delivered_at < ?) AND (m.available_at <= ?) AND (m.queue_name = ?) ORDER BY available_at ASC) a WHERE ROWNUM <= 1) FOR UPDATE',
+            'SELECT w.id AS "id", w.body AS "body", w.headers AS "headers", w.queue_name AS "queue_name", w.created_at AS "created_at", w.available_at AS "available_at", w.delivered_at AS "delivered_at" FROM messenger_messages w WHERE w.id IN(SELECT a.id FROM (SELECT m.* FROM messenger_messages m WHERE (m.delivered_at is null OR m.delivered_at < ?) AND (m.available_at <= ?) AND (m.queue_name = ?) ORDER BY available_at ASC) a WHERE ROWNUM <= 1) FOR UPDATE',
         ];
     }
 }
diff --git a/src/Symfony/Component/Messenger/Transport/Doctrine/Connection.php b/src/Symfony/Component/Messenger/Transport/Doctrine/Connection.php
@@ -193,7 +193,11 @@ public function get(): ?array
                 $sql = str_replace('SELECT a.* FROM', 'SELECT a.id FROM', $sql);
 
                 $wrappedQuery = $this->driverConnection->createQueryBuilder()
-                    ->select('w.*')
+                    ->select(
+                        'w.id AS "id", w.body AS "body", w.headers AS "headers", w.queue_name AS "queue_name", '.
+                        'w.created_at AS "created_at", w.available_at AS "available_at", '.
+                        'w.delivered_at AS "delivered_at"'
+                    )
                     ->from($this->configuration['table_name'], 'w')
                     ->where('w.id IN('.$sql.')');
 

Original file line number	Diff line number	Diff line change
`@@ -409,7 +409,7 @@ public function providePlatformSql(): iterable`
`409`	`409`
`410`	`410`	`yield 'Oracle' => [`
`411`	`411`	`new OraclePlatform(),`
`412`		`- 'SELECT w.* FROM messenger_messages w WHERE w.id IN(SELECT a.id FROM (SELECT m.* FROM messenger_messages m WHERE (m.delivered_at is null OR m.delivered_at < ?) AND (m.available_at <= ?) AND (m.queue_name = ?) ORDER BY available_at ASC) a WHERE ROWNUM <= 1) FOR UPDATE',`
	`412`	`+ 'SELECT w.id AS "id", w.body AS "body", w.headers AS "headers", w.queue_name AS "queue_name", w.created_at AS "created_at", w.available_at AS "available_at", w.delivered_at AS "delivered_at" FROM messenger_messages w WHERE w.id IN(SELECT a.id FROM (SELECT m.* FROM messenger_messages m WHERE (m.delivered_at is null OR m.delivered_at < ?) AND (m.available_at <= ?) AND (m.queue_name = ?) ORDER BY available_at ASC) a WHERE ROWNUM <= 1) FOR UPDATE',`
`413`	`413`	`];`
`414`	`414`	`}`
`415`	`415`	`}`