8000 Merge branch '2.1' · symfony/symfony@50a62da · GitHub
[go: up one dir, main page]

Skip to content

Commit 50a62da

Browse files
committed
Merge branch '2.1'
* 2.1: [HttpFoundation] reverted variable rename
2 parents 995219f + d50f9d7 commit 50a62da

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

src/Symfony/Component/HttpFoundation/Request.php

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ class Request
3535
const HEADER_CLIENT_PROTO = 'client_proto';
3636
const HEADER_CLIENT_PORT = 'client_port';
3737

38-
protected static $trustProxyData = false;
38+
protected static $trustProxy = false;
3939

4040
protected static $trustedProxies = array();
4141

@@ -466,7 +466,7 @@ public function overrideGlobals()
466466
*/
467467
public static function trustProxyData()
468468
{
469-
self::$trustProxyData = true;
469+
self::$trustProxy = true;
470470
}
471471

472472
/**
@@ -481,7 +481,7 @@ public static function trustProxyData()
481481
public static function setTrustedProxies(array $proxies)
482482
{
483483
self::$trustedProxies = $proxies;
484-
self::$trustProxyData = $proxies ? true : false;
484+
self::$trustProxy = $proxies ? true : false;
485485
}
486486

487487
/**
@@ -676,7 +676,7 @@ public function getClientIp()
676676
{
677677
$ip = $this->server->get('REMOTE_ADDR');
678678

679-
if (!self::$trustProxyData) {
679+
if (!self::$trustProxy) {
680680
return $ip;
681681
}
682682

@@ -687,7 +687,7 @@ public function getClientIp()
687687
$clientIps = array_map('trim', explode(',', $this->headers->get(self::$trustedHeaders[self::HEADER_CLIENT_IP])));
688688
$clientIps[] = $ip;
689689

690-
$trustedProxies = self::$trustProxyData && !self::$trustedProxies ? array($ip) : self::$trustedProxies;
690+
$trustedProxies = self::$trustProxy && !self::$trustedProxies ? array($ip) : self::$trustedProxies;
691691
$clientIps = array_diff($clientIps, $trustedProxies);
692692

693693
return array_pop($clientIps);
@@ -803,7 +803,7 @@ public function getScheme()
803803
*/
804804
public function getPort()
805805
{
806-
if (self::$trustProxyData && self::$trustedHeaders[self::HEADER_CLIENT_PORT] && $port = $this->headers->get(self::$trustedHeaders[self::HEADER_CLIENT_PORT])) {
806+
if (self::$trustProxy && self::$trustedHeaders[self::HEADER_CLIENT_PORT] && $port = $this->headers->get(self::$trustedHeaders[self::HEADER_CLIENT_PORT])) {
807807
return $port;
808808
}
809809

@@ -965,7 +965,7 @@ public function getQueryString()
965965
*/
966966
public function isSecure()
967967
{
968-
if (self::$trustProxyData && self::$trustedHeaders[self::HEADER_CLIENT_PROTO] && $proto = $this->headers->get(self::$trustedHeaders[self::HEADER_CLIENT_PROTO])) {
968+
if (self::$trustProxy && self::$trustedHeaders[self::HEADER_CLIENT_PROTO] && $proto = $this->headers->get(self::$trustedHeaders[self::HEADER_CLIENT_PROTO])) {
969969
return in_array(strtolower($proto), array('https', 'on', '1'));
970970
}
971971

@@ -989,7 +989,7 @@ public function isSecure()
989989
*/
990990
public function getHost()
991991
{
992-
if (self::$trustProxyData && self::$trustedHeaders[self::HEADER_CLIENT_HOST] && $host = $this->headers->get(self::$trustedHeaders[self::HEADER_CLIENT_HOST])) {
992+
if (self::$trustProxy && self::$trustedHeaders[self::HEADER_CLIENT_HOST] && $host = $this->headers->get(self::$trustedHeaders[self::HEADER_CLIENT_HOST])) {
993993
$elements = explode(',', $host);
994994

995995
$host = trim($elements[count($elements) - 1]);

src/Symfony/Component/HttpFoundation/Tests/RequestTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1228,7 +1228,7 @@ public function urlencodedStringPrefixData()
12281228
private function stopTrustingProxyData()
12291229
{
12301230
$class = new \ReflectionClass('Symfony\\Component\\HttpFoundation\\Request');
1231-
$property = $class->getProperty('trustProxyData');
1231+
$property = $class->getProperty('trustProxy');
12321232
$property->setAccessible(true);
12331233
$property->setValue(false);
12341234
}

0 commit comments

Comments
 (0)
0