Search type class into registered form namespaces too

yceruto · yceruto · commit 4fc79b95bf51 · 2017-07-28T13:41:14.000-04:00
diff --git a/src/Symfony/Component/Form/Command/FormDebugCommand.php b/src/Symfony/Component/Form/Command/FormDebugCommand.php
@@ -29,11 +29,11 @@
  */
 class FormDebugCommand extends Command
 {
-    /** @var OptionsResolver */
+    private $formRegistry;
     private $optionsResolver;
     private $parents = array();
     private $extensions = array();
-    private $formRegistry;
+    private $typesFound = array();
 
     public function __construct(FormRegistryInterface $formRegistry)
     {
@@ -62,8 +62,8 @@ protected function configure()
     protected function execute(InputInterface $input, OutputInterface $output)
     {
         $class = $input->getArgument('class');
-        if (!class_exists($class)) {
-            $class = $this->getBuiltinFormTypeClass($class);
+        if (!class_exists($class) && false === mb_strpos($class, '\\')) {
+            $class = $this->findFormTypeClass($class);
         }
 
         $type = $this->formRegistry->getType($class);
@@ -83,6 +83,13 @@ protected function execute(InputInterface $input, OutputInterface $output)
             $io->section('Type extensions');
             $io->listing(array_keys($this->extensions));
         }
+
+        if (count($this->typesFound) > 1) {
+            $io->block('Similar form types found:', null, 'info');
+            $io->listing(array_slice($this->typesFound, 1));
+            $io->comment('To search for a specific class, re-run this command with the fully-qualified class name.');
+            $io->comment(sprintf('e.g. <comment>debug:form \'%s\'</comment>', $this->typesFound[1]));
+        }
     }
 
     private function getOptionsGroup(ResolvedFormTypeInterface $type)
@@ -145,20 +152,48 @@ private function getParentOptionResolver(ResolvedFormTypeInterface $type)
         return $optionsResolver;
     }
 
-    private function getBuiltinFormTypeClass($class)
+    private function findFormTypeClass($shortClassName)
     {
-        $namespaces = array(
-            'Symfony\\Component\\Form\\Extension\\Core\\Type',
-            'Symfony\\Bridge\\Doctrine\\Form\\Type',
-        );
+        $namespaces = $this->getRegisteredFormNamespaces();
 
         foreach ($namespaces as $namespace) {
-            if (class_exists($fqcn = $namespace.'\\'.$class)) {
-                return $fqcn;
+            if (class_exists($fqcn = $namespace.'\\'.$shortClassName)) {
+                $this->typesFound[] = $fqcn;
             }
         }
 
-        throw new \InvalidArgumentException(sprintf('Could not find built-in type "%s" into the following namespaces: %s.', $class, implode(', ', $namespaces)));
+        if (0 === count($this->typesFound)) {
+            throw new \InvalidArgumentException(sprintf('Could not find type "%s" into the following namespaces: %s.', $shortClassName, implode(', ', $namespaces)));
+        }
+
+        return $this->typesFound[0];
+    }
+
+    private function getRegisteredFormNamespaces()
+    {
+        // Registered form namespaces
+        $types = array();
+        foreach ($this->formRegistry->getExtensions() as $extension) {
+            $refTypeContainer = (new \ReflectionObject($extension))->getProperty('typeContainer');
+            $refTypeContainer->setAccessible(true);
+            $typeContainer = $refTypeContainer->getValue($extension);
+
+            $refFactories = (new \ReflectionObject($typeContainer))->getProperty('factories');
+            $refFactories->setAccessible(true);
+
+            $types = array_merge($types, array_keys($refFactories->getValue($typeContainer)));
+        }
+        $registeredNamespaces = array_map(function ($class) {
+            return substr($class, 0, strrpos($class, '\\'));
+        }, $types);
+
+        // Core namespaces
+        $coreNamespaces = array(
+            'Symfony\\Bridge\\Doctrine\\Form\\Type',
+            'Symfony\\Component\\Form\\Extension\\Core\\Type',
+        );
+
+        return array_unique(array_merge($registeredNamespaces, $coreNamespaces));
     }
 
     private function buildTableContent($options)
