minor #56831 [SecurityBundle] Use %container.build_hash% instead of %kernel.secret% with the rate-limiter (nicolas-grekas)

fabpot · fabpot · commit 4fae754ee4f5 · 2024-05-21T07:46:33.000+02:00
This PR was merged into the 7.1 branch. Discussion ---------- [SecurityBundle] Use %container.build_hash% instead of %kernel.secret% with the rate-limiter | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT In #51434, we decided to hash the username and the client IP in order to anonymize logs. I propose to use %container.build_hash% instead of %kernel.secret% in order to use %kernel.secret% one less time. %container.build_hash% looks good enough to me, and it doesn't need any external configuration. Related to the discussion happening in symfony/recipes#1314 Commits ------- 574f573 [SecurityBundle] Use %container.build_hash% instead of %kernel.secret% with the rate-limiter
diff --git a/src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/LoginThrottlingFactory.php b/src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/LoginThrottlingFactory.php
@@ -76,7 +76,7 @@ public function createAuthenticator(ContainerBuilder $container, string $firewal
             $container->register($config['limiter'] = 'security.login_throttling.'.$firewallName.'.limiter', DefaultLoginRateLimiter::class)
                 ->addArgument(new Reference('limiter.'.$globalId))
                 ->addArgument(new Reference('limiter.'.$localId))
-                ->addArgument('%kernel.secret%')
+                ->addArgument('%container.build_hash%')
             ;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ public function createAuthenticator(ContainerBuilder $container, string $firewal`
`76`	`76`	`$container->register($config['limiter'] = 'security.login_throttling.'.$firewallName.'.limiter', DefaultLoginRateLimiter::class)`
`77`	`77`	`->addArgument(new Reference('limiter.'.$globalId))`
`78`	`78`	`->addArgument(new Reference('limiter.'.$localId))`
`79`		`- ->addArgument('%kernel.secret%')`
	`79`	`+ ->addArgument('%container.build_hash%')`
`80`	`80`	`;`
`81`	`81`	`}`
`82`	`82`