minor #58233 [Mime] Cache finfo objects to reduce open file handles and optimize perf (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 4e70834e5d3f · 2024-09-13T10:36:51.000+02:00
This PR was merged into the 7.2 branch. Discussion ---------- [Mime] Cache finfo objects to reduce open file handles and optimize perf | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Inspired by #58163 Commits ------- 5a1be29 [Mime] Cache finfo objects to reduce open file handles and optimize perf
diff --git a/src/Symfony/Component/Mime/FileinfoMimeTypeGuesser.php b/src/Symfony/Component/Mime/FileinfoMimeTypeGuesser.php
@@ -13,6 +13,7 @@
 
 use Symfony\Component\Mime\Exception\InvalidArgumentException;
 use Symfony\Component\Mime\Exception\LogicException;
+use Symfony\Component\Mime\Exception\RuntimeException;
 
 /**
  * Guesses the MIME type using the PECL extension FileInfo.
@@ -21,6 +22,11 @@
  */
 class FileinfoMimeTypeGuesser implements MimeTypeGuesserInterface
 {
+    /**
+     * @var array<string, \finfo>
+     */
+    private static $finfoCache = [];
+
     /**
      * @param string|null $magicFile A magic file to use with the finfo instance
      *
@@ -46,10 +52,12 @@ public function guessMimeType(string $path): ?string
             throw new LogicException(\sprintf('The "%s" guesser is not supported.', __CLASS__));
         }
 
-        if (false === $finfo = new \finfo(\FILEINFO_MIME_TYPE, $this->magicFile)) {
-            return null;
+        try {
+            $finfo = self::$finfoCache[$this->magicFile] ??= new \finfo(\FILEINFO_MIME_TYPE, $this->magicFile);
+        } catch (\Exception $e) {
+            throw new RuntimeException($e->getMessage());
         }
-        $mimeType = $finfo->file($path);
+        $mimeType = $finfo->file($path) ?: null;
 
         if ($mimeType && 0 === (\strlen($mimeType) % 2)) {
             $mimeStart = substr($mimeType, 0, \strlen($mimeType) >> 1);
