bug #40658 [RateLimiter] Fix sleep value (jderusse)

nicolas-grekas · nicolas-grekas · commit 4d23fec0215f · 2021-04-01T12:20:53.000+02:00
This PR was merged into the 5.2 branch. Discussion ---------- [RateLimiter] Fix sleep value | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #40656 | License | MIT | Doc PR | sleep vs usleep Commits ------- cf66399 Fix sleep value
diff --git a/src/Symfony/Component/RateLimiter/RateLimit.php b/src/Symfony/Component/RateLimiter/RateLimit.php
@@ -67,6 +67,11 @@ public function getLimit(): int
 
     public function wait(): void
     {
-        sleep(($this->retryAfter->getTimestamp() - time()) * 1e6);
+        $delta = $this->retryAfter->getTimestamp() - time();
+        if ($delta <= 0) {
+            return;
+        }
+
+        sleep($delta);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -67,6 +67,11 @@ public function getLimit(): int`
`67`	`67`
`68`	`68`	`public function wait(): void`
`69`	`69`	`{`
`70`		`- sleep(($this->retryAfter->getTimestamp() - time()) * 1e6);`
	`70`	`+ $delta = $this->retryAfter->getTimestamp() - time();`
	`71`	`+ if ($delta <= 0) {`
	`72`	`+ return;`
	`73`	`+ }`
	`74`	`+`
	`75`	`+ sleep($delta);`
`71`	`76`	`}`
`72`	`77`	`}`