minor #47628 [Mime] Improve error message on invalid form field (dunglas)

fabpot · fabpot · commit 4d098379440e · 2022-09-20T20:17:43.000+02:00
This PR was merged into the 6.2 branch. Discussion ---------- [Mime] Improve error message on invalid form field | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no  | Deprecations? | no  | Tickets | n/a | License | MIT | Doc PR | n/a Currently, when you forget to set the subject of a mail, you get a weird error that is hard to debug. This patch improves the error message. Commits ------- 77d5798 [Mime] Improve error message on invalid form field
diff --git a/src/Symfony/Component/Mime/Part/Multipart/FormDataPart.php b/src/Symfony/Component/Mime/Part/Multipart/FormDataPart.php
@@ -34,7 +34,7 @@ public function __construct(array $fields = [])
 
         foreach ($fields as $name => $value) {
             if (!\is_string($value) && !\is_array($value) && !$value instanceof TextPart) {
-                throw new InvalidArgumentException(sprintf('A form field value can only be a string, an array, or an instance of TextPart ("%s" given).', get_debug_type($value)));
+                throw new InvalidArgumentException(sprintf('The value of the form field "%s" can only be a string, an array, or an instance of TextPart ("%s" given).', $name, get_debug_type($value)));
             }
 
             $this->fields[$name] = $value;

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ public function __construct(array $fields = [])`
`34`	`34`
`35`	`35`	`foreach ($fields as $name => $value) {`
`36`	`36`	`if (!\is_string($value) && !\is_array($value) && !$value instanceof TextPart) {`
`37`		`- throw new InvalidArgumentException(sprintf('A form field value can only be a string, an array, or an instance of TextPart ("%s" given).', get_debug_type($value)));`
	`37`	`+ throw new InvalidArgumentException(sprintf('The value of the form field "%s" can only be a string, an array, or an instance of TextPart ("%s" given).', $name, get_debug_type($value)));`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`$this->fields[$name] = $value;`