feature #24631 [Form] Fix FormEvents::* constant and value matching (yceruto, javiereguiluz)

fabpot · fabpot · commit 4c414d8136f0 · 2017-10-19T11:52:46.000-07:00
This PR was merged into the 4.0-dev branch. Discussion ---------- [Form] Fix FormEvents::* constant and value matching | Q | A | ------------- | --- | Branch? | 4.0 | Bug fix? | no | New feature? | no | BC breaks? | yes (ppl rely on const value directly, very weird) | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24615 | License | MIT | Doc PR | - > #24615 (comment) by @stof: Yeah, I think we could change this in 4.0 without a big impact (btw, I think our BC policy even allows it for this case). There is one case where people will use the event name rather than the constant: the kernel.event_listener tag (and recent versions can even use the constant in YAML files). But this won't be the case for this event, as form events are not dispatched in the main dispatcher anyway. Commits ------- 944931a Minor reword 0ee856a Update UPGRADE-4.0.md 0fc2282 fix the constant value to be consistent with the name
diff --git a/UPGRADE-4.0.md b/UPGRADE-4.0.md
@@ -226,6 +226,10 @@ Finder
 Form
 ----
 
+* The values of the `FormEvents::*` constants have been updated to match the
+  constant names. You should only update your application if you relied on the
+  constant values instead of their names.
+
  * The `choices_as_values` option of the `ChoiceType` has been removed.
 
  * Support for data objects that implements both `Traversable` and
diff --git a/src/Symfony/Component/Form/FormEvents.php b/src/Symfony/Component/Form/FormEvents.php
@@ -31,7 +31,7 @@ final class FormEvents
      *
      * @Event("Symfony\Component\Form\FormEvent")
      */
-    const PRE_SUBMIT = 'form.pre_bind';
+    const PRE_SUBMIT = 'form.pre_submit';
 
     /**
      * The SUBMIT event is dispatched just before the Form::submit() method
@@ -41,7 +41,7 @@ final class FormEvents
      *
      * @Event("Symfony\Component\Form\FormEvent")
      */
-    const SUBMIT = 'form.bind';
+    const SUBMIT = 'form.submit';
 
     /**
      * The FormEvents::POST_SUBMIT event is dispatched after the Form::submit()
@@ -51,7 +51,7 @@ final class FormEvents
      *
      * @Event("Symfony\Component\Form\FormEvent")
      */
-    const POST_SUBMIT = 'form.post_bind';
+    const POST_SUBMIT = 'form.post_submit';
 
     /**
      * The FormEvents::PRE_SET_DATA event is dispatched at the beginning of the Form::setData() method.
