[HttpFoundation] fix compat of tests with PHP 7.3

nicolas-grekas · nicolas-grekas · commit 4c1f7c5877ce · 2018-10-02T18:23:27.000+02:00
diff --git a/src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php b/src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php
@@ -153,7 +153,7 @@ public function start()
         if (null !== $this->emulateSameSite) {
             $originalCookie = SessionUtils::popSessionCookie(session_name(), session_id());
             if (null !== $originalCookie) {
-                header(sprintf('%s; samesite=%s', $originalCookie, $this->emulateSameSite));
+                header(sprintf('%s; SameSite=%s', $originalCookie, $this->emulateSameSite));
             }
         }
 
diff --git a/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/Fixtures/with_samesite.expected b/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/Fixtures/with_samesite.expected
@@ -11,6 +11,6 @@ Array
 (
     [0] => Content-Type: text/plain; charset=utf-8
     [1] => Cache-Control: max-age=0, private, must-revalidate
-    [2] => Set-Cookie: sid=random_session_id; path=/; secure; HttpOnly; samesite=lax
+    [2] => Set-Cookie: sid=random_session_id; path=/; secure; HttpOnly; SameSite=lax
 )
 shutdown

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ public function start()`
`153`	`153`	`if (null !== $this->emulateSameSite) {`
`154`	`154`	`$originalCookie = SessionUtils::popSessionCookie(session_name(), session_id());`
`155`	`155`	`if (null !== $originalCookie) {`
`156`		`- header(sprintf('%s; samesite=%s', $originalCookie, $this->emulateSameSite));`
	`156`	`+ header(sprintf('%s; SameSite=%s', $originalCookie, $this->emulateSameSite));`
`157`	`157`	`}`
`158`	`158`	`}`
`159`	`159`
Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,6 @@ Array`
`11`	`11`	`(`
`12`	`12`	`[0] => Content-Type: text/plain; charset=utf-8`
`13`	`13`	`[1] => Cache-Control: max-age=0, private, must-revalidate`
`14`		`- [2] => Set-Cookie: sid=random_session_id; path=/; secure; HttpOnly; samesite=lax`
	`14`	`+ [2] => Set-Cookie: sid=random_session_id; path=/; secure; HttpOnly; SameSite=lax`
`15`	`15`	`)`
`16`	`16`	`shutdown`