Allow terminal dimensions to be set to 0 (unbounded)

duncan3dc · duncan3dc · commit 4c1b00189190 · 2017-04-11T16:41:42.000+01:00
diff --git a/src/Symfony/Component/Console/Terminal.php b/src/Symfony/Component/Console/Terminal.php
@@ -23,8 +23,9 @@ class Terminal
      */
     public function getWidth()
     {
-        if ($width = trim(getenv('COLUMNS'))) {
-            return (int) $width;
+        $width = getenv('COLUMNS');
+        if (false !== $width) {
+            return (int) trim($width);
         }
 
         if (null === self::$width) {
@@ -41,8 +42,9 @@ public function getWidth()
      */
     public function getHeight()
     {
-        if ($height = trim(getenv('LINES'))) {
-            return (int) $height;
+        $height = getenv('LINES');
+        if (false !== $height) {
+            return (int) trim($height);
         }
 
         if (null === self::$height) {
diff --git a/src/Symfony/Component/Console/Tests/TerminalTest.php b/src/Symfony/Component/Console/Tests/TerminalTest.php
@@ -30,4 +30,15 @@ public function test()
         $this->assertSame(120, $terminal->getWidth());
         $this->assertSame(60, $terminal->getHeight());
     }
+
+    public function test_zero_values()
+    {
+        putenv('COLUMNS=0');
+        putenv('LINES=0');
+
+        $terminal = new Terminal();
+
+        $this->assertSame(0, $terminal->getWidth());
+        $this->assertSame(0, $terminal->getHeight());
+    }
 }
