minor optimalization at bundle initialization

Gábor Tóth · fabpot · commit 4ba6c0b90e83 · 2013-11-30T13:44:15.000+01:00
fast check to avoid six array method calls
diff --git a/src/Symfony/Component/HttpKernel/Kernel.php b/src/Symfony/Component/HttpKernel/Kernel.php
@@ -495,7 +495,7 @@ protected function initializeBundles()
         }
 
         // look for orphans
-        if (count($diff = array_values(array_diff(array_keys($directChildren), array_keys($this->bundles))))) {
+        if (!empty($directChildren) && count($diff = array_values(array_diff(array_keys($directChildren), array_keys($this->bundles))))) {
             throw new \LogicException(sprintf('Bundle "%s" extends bundle "%s", which is not registered.', $directChildren[$diff[0]], $diff[0]));
         }
 

Original file line number	Diff line number	Diff line change
`@@ -495,7 +495,7 @@ protected function initializeBundles()`
`495`	`495`	`}`
`496`	`496`
`497`	`497`	`// look for orphans`
`49 55FB 8`		`- if (count($diff = array_values(array_diff(array_keys($directChildren), array_keys($this->bundles))))) {`
	`498`	`+ if (!empty($directChildren) && count($diff = array_values(array_diff(array_keys($directChildren), array_keys($this->bundles))))) {`
`499`	`499`	`throw new \LogicException(sprintf('Bundle "%s" extends bundle "%s", which is not registered.', $directChildren[$diff[0]], $diff[0]));`
`500`	`500`	`}`
`501`	`501`