minor #46945 [HttpKernel] Declare properties used by CacheAttributeListenerTest explicitly (derrabus)

chalasr · chalasr · commit 4b4f33442be3 · 2022-07-14T23:53:50.000+02:00
This PR was merged into the 6.2 branch. Discussion ---------- [HttpKernel] Declare properties used by CacheAttributeListenerTest explicitly | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A A test case introduced by #46880 triggers deprecation notices on PHP 8.2 because none of the properties used is declared. This PR fixes the build by adding explicit property declarations. Commits ------- f0d0799 [HttpKernel] Declare properties used by CacheAttributeListenerTest explicitly
diff --git a/src/Symfony/Component/HttpKernel/Tests/EventListener/CacheAttributeListenerTest.php b/src/Symfony/Component/HttpKernel/Tests/EventListener/CacheAttributeListenerTest.php
@@ -24,6 +24,12 @@
 
 class CacheAttributeListenerTest extends TestCase
 {
+    private CacheAttributeListener $listener;
+    private Response $response;
+    private Cache $cache;
+    private Request $request;
+    private ResponseEvent $event;
+
     protected function setUp(): void
     {
         $this->listener = new CacheAttributeListener();
@@ -294,12 +300,12 @@ public function testAttribute()
         $this->assertSame(CacheAttributeController::CLASS_SMAXAGE, $response->getMaxAge());
     }
 
-    private function createRequest(Cache $cache = null)
+    private function createRequest(Cache $cache): Request
     {
         return new Request([], [], ['_cache' => [$cache]]);
     }
 
-    private function createEventMock(Request $request, Response $response)
+    private function createEventMock(Request $request, Response $response): ResponseEvent
     {
         return new ResponseEvent($this->getKernel(), $request, HttpKernelInterface::MAIN_REQUEST, $response);
     }

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,12 @@`
`24`	`24`
`25`	`25`	`class CacheAttributeListenerTest extends TestCase`
`26`	`26`	`{`
	`27`	`+ private CacheAttributeListener $listener;`
	`28`	`+ private Response $response;`
	`29`	`+ private Cache $cache;`
	`30`	`+ private Request $request;`
	`31`	`+ private ResponseEvent $event;`
	`32`	`+`
`27`	`33`	`protected function setUp(): void`
`28`	`34`	`{`
`29`	`35`	`$this->listener = new CacheAttributeListener();`
`@@ -294,12 +300,12 @@ public function testAttribute()`
`294`	`300`	`$this->assertSame(CacheAttributeController::CLASS_SMAXAGE, $response->getMaxAge());`
`295`	`301`	`}`
`296`	`302`
`297`		`- private function createRequest(Cache $cache = null)`
	`303`	`+ private function c 6B18 reateRequest(Cache $cache): Request`
`298`	`304`	`{`
`299`	`305`	`return new Request([], [], ['_cache' => [$cache]]);`
`300`	`306`	`}`
`301`	`307`
`302`		`- private function createEventMock(Request $request, Response $response)`
	`308`	`+ private function createEventMock(Request $request, Response $response): ResponseEvent`
`303`	`309`	`{`
`304`	`310`	`return new ResponseEvent($this->getKernel(), $request, HttpKernelInterface::MAIN_REQUEST, $response);`
`305`	`311`	`}`