Throw error if maximum block limit is reached for slack message options

norkunas · norkunas · commit 4adb17d6f824 · 2021-07-14T06:30:50.000+03:00
diff --git a/src/Symfony/Component/Notifier/Bridge/Slack/SlackOptions.php b/src/Symfony/Component/Notifier/Bridge/Slack/SlackOptions.php
@@ -97,6 +97,10 @@ public function asUser(bool $bool): self
      */
     public function block(SlackBlockInterface $block): self
     {
+        if (50 === \count($this->options['blocks'] ?? [])) {
+            throw new \LogicException('Maximum number of blocks should not exceed 50.');
+        }
+
         $this->options['blocks'][] = $block->toArray();
 
         return $this;
diff --git a/src/Symfony/Component/Notifier/Bridge/Slack/Tests/SlackOptionsTest.php b/src/Symfony/Component/Notifier/Bridge/Slack/Tests/SlackOptionsTest.php
@@ -14,6 +14,7 @@
 use PHPUnit\Framework\TestCase;
 use Symfony\Bridge\PhpUnit\ExpectDeprecationTrait;
 use Symfony\Component\Notifier\Bridge\Slack\Block\SlackDividerBlock;
+use Symfony\Component\Notifier\Bridge\Slack\Block\SlackSectionBlock;
 use Symfony\Component\Notifier\Bridge\Slack\SlackOptions;
 use Symfony\Component\Notifier\Notification\Notification;
 
@@ -187,4 +188,17 @@ public function fromNotificationProvider(): iterable
             (new Notification($subject))->emoji($emoji)->content($content),
         ];
     }
+
+    public function testThrowsWhenBlocksLimitReached()
+    {
+        $options = new SlackOptions();
+        for ($i = 0; $i < 50; ++$i) {
+            $options->block(new SlackSectionBlock());
+        }
+
+        $this->expectException(\LogicException::class);
+        $this->expectExceptionMessage('Maximum number of blocks should not exceed 50.');
+
+        $options->block(new SlackSectionBlock());
+    }
 }
