8000 [Mailer] comments · symfony/symfony@49e4318 · GitHub
[go: up one dir, main page]
Skip to content

Commit 49e4318

Browse files
PEtanguyPEtanguy
committed
[Mailer] comments
1 parent 5fb6f9c commit 49e4318

File tree

5 files changed

+44
-44
lines changed

5 files changed

+44
-44
lines changed

‎src/Symfony/Component/Mailer/Bridge/Brevo/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@ CHANGELOG
44
6.3
55
---
66

7-
* Added the bridge as a replacement of the deprecated Sendiblue one.
7+
* Added the bridge as a replacement of the deprecated Sendinblue one.

‎src/Symfony/Component/Mailer/Bridge/Brevo/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
Brevo Bridge
2-
=================
2+
============
33

44
Provides Brevo integration for Symfony Mailer.
55

‎src/Symfony/Component/Mailer/Bridge/Brevo/Transport/BrevoApiTransport.php

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -74,22 +74,22 @@ protected function doSendApi(SentMessage $sentMessage, Email $email, Envelope $e
7474
}
7575

7676
/**
77-
* @return array<int, string>
77+
* @return list<array{email: string, name?: string}>
7878
*/
7979
protected function stringifyAddresses(array $addresses): array
8080
{
81-
$stringifiedAddresses = [];
81+
$formattedAddresses = [];
8282
foreach ($addresses as $address) {
83-
$stringifiedAddresses[] = $this->stringifyAddress($address);
83+
$formattedAddresses[] = $this->formatAddress($address);
8484
}
8585

86-
return $stringifiedAddresses;
86+
return $formattedAddresses;
8787
}
8888

8989
private function getPayload(Email $email, Envelope $envelope): array
9090
{
9191
$payload = [
92-
'sender' => $this->stringifyAddress($envelope->getSender()),
92+
'sender' => $this->formatAddress($envelope->getSender()),
9393
'to' => $this->stringifyAddresses($this->getRecipients($email, $envelope)),
9494
'subject' => $email->getSubject(),
9595
];
@@ -170,15 +170,15 @@ private function prepareHeadersAndTags(Headers $headers): array
170170
return $headersAndTags;
171171
}
172172

173-
private function stringifyAddress(Address $address): array
173+
private function formatAddress(Address $address): array
174174
{
175-
$stringifiedAddress = ['email' => $address->getAddress()];
175+
$formattedAddress = ['email' => $address->getAddress()];
176176

177177
if ($address->getName()) {
178-
$stringifiedAddress['name'] = $address->getName();
178+
$formattedAddress['name'] = $address->getName();
179179
}
180180

181-
return $stringifiedAddress;
181+
return $formattedAddress;
182182
}
183183

184184
private function getEndpoint(): ?string

‎src/Symfony/Component/Mailer/Bridge/Brevo/composer.json

Lines changed: 32 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,35 @@
11
{
2-
"name": "symfony/brevo-mailer",
3-
"type": "symfony-mailer-bridge",
4-
"description": "Symfony Brevo Mailer Bridge - formerly Sendinblue",
5-
"keywords": [],
6-
"homepage": "https://symfony.com",
7-
"license": "MIT",
8-
"authors": [
9-
{
10-
"name": "Pierre Tanguy",
11-
"homepage": "https://github.com/petanguy"
2+
"name": "symfony/brevo-mailer",
3+
"type": "symfony-mailer-bridge",
4+
"description": "Symfony Brevo Mailer Bridge",
5+
"keywords": [],
6+
"homepage": "https://symfony.com",
7+
"license": "MIT",
8+
"authors": [
9+
{
10+
"name": "Pierre Tanguy",
11+
"homepage": "https://github.com/petanguy"
12+
},
13+
{
14+
"name": "Symfony Community",
15+
"homepage": "https://symfony.com/contributors"
16+
}
17+
],
18+
"require": {
19+
"php": ">=8.1",
20+
"symfony/mailer": "^5.4.21|^6.2.7"
1221
},
13-
{
14-
"name": "Symfony Community",
15-
"homepage": "https://symfony.com/contributors"
16-
}
17-
],
18-
"require": {
19-
"php": ">=8.1",
20-
"symfony/mailer": "^5.4.21|^6.2.7"
21-
},
22-
"require-dev": {
23-
"symfony/http-client": "^5.4|^6.0"
24-
},
25-
"conflict": {
26-
"symfony/mime": "<6.2"
27-
},
28-
"autoload": {
29-
"psr-4": { "Symfony\\Component\\Mailer\\Bridge\\Brevo\\": "" },
30-
"exclude-from-classmap": [
31-
"/Tests/"
32-
]
33-
},
34-
"minimum-stability": "dev"
22+
"require-dev": {
23+
"symfony/http-client": "^5.4|^6.0"
24+
},
25+
"conflict": {
26+
"symfony/mime": "<6.2"
27+
},
28+
"autoload": {
29+
"psr-4": { "Symfony\\Component\\Mailer\\Bridge\\Brevo\\": "" },
30+
"exclude-from-classmap": [
31+
"/Tests/"
32+
]
33+
},
34+
"minimum-stability": "dev"
3535
}

‎src/Symfony/Component/Mailer/Bridge/Sendinblue/composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "symfony/sendinblue-mailer",
33
"type": "symfony-mailer-bridge",
4-
"description": "Symfony Sendinblue Mailer Bridge - deprecated",
4+
"description": "Symfony Sendinblue Mailer Bridge",
55
"keywords": [],
66
"homepage": "https://symfony.com",
77
"license": "MIT",

0 commit comments

Comments
 (0)
0