[Console] Better required argument check in InputArgument

jnoordsij · jnoordsij · commit 484ac81f71f6 · 2022-05-05T14:55:43.000+02:00
Use better check for required arguments in InputArgument when setting default value,
to correctly account for combining multiple mode options
diff --git a/src/Symfony/Component/Console/Input/InputArgument.php b/src/Symfony/Component/Console/Input/InputArgument.php
@@ -92,7 +92,7 @@ public function isArray()
      */
     public function setDefault($default = null)
     {
-        if (self::REQUIRED === $this->mode && null !== $default) {
+        if ($this->isRequired() && null !== $default) {
             throw new LogicException('Cannot set a default value except for InputArgument::OPTIONAL mode.');
         }
 

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ public function isArray()`
`92`	`92`	*/
`93`	`93`	`public function setDefault($default = null)`
`94`	`94`	`{`
`95`		`- if (self::REQUIRED === $this->mode && null !== $default) {`
	`95`	`+ if ($this->isRequired() && null !== $default) {`
`96`	`96`	`throw new LogicException('Cannot set a default value except for InputArgument::OPTIONAL mode.');`
`97`	`97`	`}`
`98`	`98`