[PropertyInfo][DoctrineBridge] The bigint Doctrine's type must be converted to string

dunglas · dunglas · commit 47d5e6b82c91 · 2017-05-31T12:58:03.000+02:00
diff --git a/src/Symfony/Bridge/Doctrine/PropertyInfo/DoctrineExtractor.php b/src/Symfony/Bridge/Doctrine/PropertyInfo/DoctrineExtractor.php
@@ -174,13 +174,13 @@ private function getPhpType($doctrineType)
     {
         switch ($doctrineType) {
             case DBALType::SMALLINT:
-            case DBALType::BIGINT:
             case DBALType::INTEGER:
                 return Type::BUILTIN_TYPE_INT;
 
             case DBALType::FLOAT:
                 return Type::BUILTIN_TYPE_FLOAT;
 
+            case DBALType::BIGINT:
             case DBALType::STRING:
             case DBALType::TEXT:
             case DBALType::GUID:
@@ -196,9 +196,6 @@ private function getPhpType($doctrineType)
 
             case DBALType::OBJECT:
                 return Type::BUILTIN_TYPE_OBJECT;
-
-            default:
-                return;
         }
     }
 }
diff --git a/src/Symfony/Bridge/Doctrine/Tests/PropertyInfo/DoctrineExtractorTest.php b/src/Symfony/Bridge/Doctrine/Tests/PropertyInfo/DoctrineExtractorTest.php
@@ -55,6 +55,7 @@ public function testGetProperties()
                 'bool',
                 'binary',
                 'customFoo',
+                'bigint',
                 'foo',
                 'bar',
                 'indexedBar',
@@ -76,6 +77,7 @@ public function typesProvider()
         return array(
             array('id', array(new Type(Type::BUILTIN_TYPE_INT))),
             array('guid', array(new Type(Type::BUILTIN_TYPE_STRING))),
+            array('bigint', array(new Type(Type::BUILTIN_TYPE_STRING))),
             array('float', array(new Type(Type::BUILTIN_TYPE_FLOAT))),
             array('decimal', array(new Type(Type::BUILTIN_TYPE_STRING))),
             array('bool', array(new Type(Type::BUILTIN_TYPE_BOOL))),
diff --git a/src/Symfony/Bridge/Doctrine/Tests/PropertyInfo/Fixtures/DoctrineDummy.php b/src/Symfony/Bridge/Doctrine/Tests/PropertyInfo/Fixtures/DoctrineDummy.php
@@ -11,6 +11,7 @@
 
 namespace Symfony\Bridge\Doctrine\Tests\PropertyInfo\Fixtures;
 
+use Doctrine\ORM\Mapping as ORM;
 use Doctrine\ORM\Mapping\Column;
 use Doctrine\ORM\Mapping\Entity;
 use Doctrine\ORM\Mapping\Id;
@@ -90,5 +91,10 @@ class DoctrineDummy
      */
     private $customFoo;
 
+    /**
+     * @Column(type="bigint")
+     */
+    private $bigint;
+
     public $notMapped;
 }

Original file line number	Diff line number	Diff line change
`@@ -174,13 +174,13 @@ private function getPhpType($doctrineType)`
`174`	`174`	`{`
`175`	`175`	`switch ($doctrineType) {`
`176`	`176`	`case DBALType::SMALLINT:`
`177`		`- case DBALType::BIGINT:`
`178`	`177`	`case DBALType::INTEGER:`
`179`	`178`	`return Type::BUILTIN_TYPE_INT;`
`180`	`179`
`181`	`180`	`case DBALType::FLOAT:`
`182`	`181`	`return Type::BUILTIN_TYPE_FLOAT;`
`183`	`182`
	`183`	`+ case DBALType::BIGINT:`
`184`	`184`	`case DBALType::STRING:`
`185`	`185`	`case DBALType::TEXT:`
`186`	`186`	`case DBALType::GUID:`
`@@ -196,9 +196,6 @@ private function getPhpType($doctrineType)`
`196`	`196`
`197`	`197`	`case DBALType::OBJECT:`
`198`	`198`	`return Type::BUILTIN_TYPE_OBJECT;`
`199`		`-`
`200`		`- default:`
`201`		`- return;`
`202`	`199`	`}`
`203`	`200`	`}`
`204`	`201`	`}`