Add deprecation

VincentLanglet · VincentLanglet · commit 47875dff3cf5 · 2020-10-04T17:47:37.000+02:00
diff --git a/src/Symfony/Component/Form/ChoiceList/Factory/CachingFactoryDecorator.php b/src/Symfony/Component/Form/ChoiceList/Factory/CachingFactoryDecorator.php
@@ -183,6 +183,10 @@ public function createListFromLoader(ChoiceLoaderInterface $loader, $value = nul
      */
     public function createView(ChoiceListInterface $list, $preferredChoices = null, $label = null, $index = null, $groupBy = null, $attr = null/*, $labelTranslationParameters = []*/)
     {
+        if (\count(\func_get_args()) < 7) {
+            trigger_deprecation('symfony/form', '5.2', 'Calling %s without passing the label translation parameters is deprecated.', __METHOD__);
+        }
+
         $labelTranslationParameters = \func_get_args()[6] ?? [];
         $cache = true;
 
diff --git a/src/Symfony/Component/Form/ChoiceList/Factory/DefaultChoiceListFactory.php b/src/Symfony/Component/Form/ChoiceList/Factory/DefaultChoiceListFactory.php
@@ -71,6 +71,10 @@ public function createListFromLoader(ChoiceLoaderInterface $loader, callable $va
      */
     public function createView(ChoiceListInterface $list, $preferredChoices = null, $label = null, callable $index = null, callable $groupBy = null, $attr = null/*, $labelTranslationParameters = []*/)
     {
+        if (\count(\func_get_args()) < 7) {
+            trigger_deprecation('symfony/form', '5.2', 'Calling %s without passing the label translation parameters is deprecated.', __METHOD__);
+        }
+
         $labelTranslationParameters = \func_get_args()[6] ?? [];
         $preferredViews = [];
         $preferredViewsOrder = [];
diff --git a/src/Symfony/Component/Form/ChoiceList/Factory/PropertyAccessDecorator.php b/src/Symfony/Component/Form/ChoiceList/Factory/PropertyAccessDecorator.php
@@ -156,6 +156,10 @@ public function createListFromLoader(ChoiceLoaderInterface $loader, $value = nul
      */
     public function createView(ChoiceListInterface $list, $preferredChoices = null, $label = null, $index = null, $groupBy = null, $attr = null/*, $labelTranslationParameters = []*/)
     {
+        if (\count(\func_get_args()) < 7) {
+            trigger_deprecation('symfony/form', '5.2', 'Calling %s without passing the label translation parameters is deprecated.', __METHOD__);
+        }
+
         $labelTranslationParameters = \func_get_args()[6] ?? [];
         $accessor = $this->propertyAccessor;
 
