8000 minor #54389 [HttpFoundation] fix UriSigner tests (xabbuh) · symfony/symfony@471bd06 · GitHub
[go: up one dir, main page]
Skip to content

Commit 471bd06

Browse files
fabpotfabpot
committed
minor #54389 [HttpFoundation] fix UriSigner tests (xabbuh)
This PR was merged into the 7.1 branch. Discussion ---------- [HttpFoundation] fix UriSigner tests | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT Commits ------- 868fe0a fix UriSigner tests
2 parents b5ee977 + 868fe0a commit 471bd06

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

‎src/Symfony/Component/HttpFoundation/Tests/UriSignerTest.php

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@
1616
use Symfony\Component\HttpFoundation\Request;
1717
use Symfony\Component\HttpFoundation\UriSigner;
1818

19+
/**
20+
* @group time-sensitive
21+
*/
1922
class UriSignerTest extends TestCase
2023
{
2124
public function testSign()
@@ -71,8 +74,8 @@ public function testCheckWithDifferentArgSeparator()
7174
$this->assertTrue($signer->check($signer->sign('http://example.com/foo?foo=bar&baz=bay')));
7275

7376
$this->assertSame(
74-
'http://example.com/foo?_expiration=4070908800&_hash=xfui5FoP0vbD9Cp7pI0tHnqR1Fmj2UARqkIUw7SZVfQ%3D&baz=bay&foo=bar',
75-
$signer->sign('http://example.com/foo?foo=bar&baz=bay', new \DateTimeImmutable('2099-01-01 00:00:00'))
77+
'http://example.com/foo?_expiration=2145916800&_hash=xLhnPMzV3KqqHaaUffBUJvtRDAZ4%2FZ9Y8Sw%2BgmS%2B82Q%3D&baz=bay&foo=bar',
78+
$signer->sign('http://example.com/foo?foo=bar&baz=bay', new \DateTimeImmutable('2038-01-01 00:00:00', new \DateTimeZone('UTC')))
7679
);
7780
$this->assertTrue($signer->check($signer->sign('http://example.com/foo?foo=bar&baz=bay', new \DateTimeImmutable('2099-01-01 00:00:00'))));
7881
}
@@ -101,8 +104,8 @@ public function testCheckWithDifferentParameter()
101104
$this->assertTrue($signer->check($signer->sign('http://example.com/foo?foo=bar&baz=bay')));
102105

103106
$this->assertSame(
104-
'http://example.com/foo?abc=4070908800&baz=bay&foo=bar&qux=hdhUhBVPpzKJdz5ZjC%2FkLvtOYdGKOvKVOczmmMIZK0A%3D',
105-
$signer->sign('http://example.com/foo?foo=bar&baz=bay', new \DateTimeImmutable('2099-01-01 00:00:00'))
107+
'http://example.com/foo?abc=2145916800&baz=bay&foo=bar&qux=kE4rK2MzeiwrYAKy%2B%2FGKvKA6bnzqCbACBdpC3yGnPVU%3D',
108+
$signer->sign('http://example.com/foo?foo=bar&baz=bay', new \DateTimeImmutable('2038-01-01 00:00:00', new \DateTimeZone('UTC')))
106109
);
107110
$this->assertTrue($signer->check($signer->sign('http://example.com/foo?foo=bar&baz=bay', new \DateTimeImmutable('2099-01-01 00:00:00'))));
108111
}
@@ -119,8 +122,8 @@ public function testSignerWorksWithFragments()
119122
$this->assertTrue($signer->check($signer->sign('http://example.com/foo?bar=foo&foo=bar#foobar')));
120123

121124
$this->assertSame(
122-
'http://example.com/foo?_expiration=4070908800&_hash=qHl626U5d7LMsVtBxPt9GNzysdSxyOQ1fHA59Y1ib0Y%3D&bar=foo&foo=bar#foobar',
123-
$signer->sign('http://example.com/foo?bar=foo&foo=bar#foobar', new \DateTimeImmutable('2099-01-01 00:00:00'))
125+
'http://example.com/foo?_expiration=2145916800&_hash=jTdrIE9MJSorNpQmkX6tmOtocxXtHDzIJawcAW4IFYo%3D&bar=foo&foo=bar#foobar',
126+
$signer->sign('http://example.com/foo?bar=foo&foo=bar#foobar', new \DateTimeImmutable('2038-01-01 00:00:00', new \DateTimeZone('UTC')))
124127
);
125128

126129
$this->assertTrue($signer->check($signer->sign('http://example.com/foo?bar=foo&foo=bar#foobar', new \DateTimeImmutable('2099-01-01 00:00:00'))));
@@ -130,7 +133,7 @@ public function testSignWithUriExpiration()
130133
{
131134
$signer = new UriSigner('foobar');
132135

133-
$this->assertSame($signer->sign('http://example.com/foo?foo=bar&bar=foo', new \DateTimeImmutable('2099-01-01 00:00:00')), $signer->sign('http://example.com/foo?bar=foo&foo=bar', 4070908800));
136+
$this->assertSame($signer->sign('http://example.com/foo?foo=bar&bar=foo', new \DateTimeImmutable('2038-01-01 00:00:00', new \DateTimeZone('UTC'))), $signer->sign('http://example.com/foo?bar=foo&foo=bar', 2145916800));
134137
}
135138

136139
public function testSignWithoutExpirationAndWithReservedHashParameter()

0 commit comments

Comments
 (0)
0