minor #18227 [Routing] small refactoring for scheme requirement (Tobion)

fabpot · fabpot · commit 46e82299e283 · 2016-03-21T06:55:59.000-07:00
This PR was merged into the 2.7 branch. Discussion ---------- [Routing] small refactoring for scheme requirement | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | refactoring | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #18106 | License | MIT | Doc PR | Commits ------- 85f5e01 [Routing] small refactoring for scheme requirement
diff --git a/src/Symfony/Component/Routing/Generator/UrlGenerator.php b/src/Symfony/Component/Routing/Generator/UrlGenerator.php
@@ -202,16 +202,7 @@ protected function doGenerate($variables, $defaults, $requirements, $tokens, $pa
             $scheme = $this->context->getScheme();
 
             if ($requiredSchemes) {
-                $schemeMatched = false;
-                foreach ($requiredSchemes as $requiredScheme) {
-                    if ($scheme === $requiredScheme) {
-                        $schemeMatched = true;
-
-                        break;
-                    }
-                }
-
-                if (!$schemeMatched) {
+                if (!in_array($scheme, $requiredSchemes, true)) {
                     $referenceType = self::ABSOLUTE_URL;
                     $scheme = current($requiredSchemes);
                 }
