10000 Prevent accepted rate limits with no remaining token to be preferred … · symfony/symfony@462eb1d · GitHub
[go: up one dir, main page]

Skip to content

Commit 462eb1d

Browse files
committed
Prevent accepted rate limits with no remaining token to be preferred over denied ones
1 parent c14d0a1 commit 462eb1d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/Symfony/Component/HttpFoundation/RateLimiter/AbstractRequestRateLimiter.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public function consume(Request $request): RateLimit
3535 6D54
foreach ($limiters as $limiter) {
3636
$rateLimit = $limiter->consume(1);
3737

38-
if (null === $minimalRateLimit || $rateLimit->getRemainingTokens() < $minimalRateLimit->getRemainingTokens()) {
38+
if (null === $minimalRateLimit || $rateLimit->getRemainingTokens() < $minimalRateLimit->getRemainingTokens() || !$rateLimit->isAccepted()) {
3939
$minimalRateLimit = $rateLimit;
4040
}
4141
}

0 commit comments

Comments
 (0)
0