bug #21220 [DI] Fix missing new line after private alias (ogizanagi)

fabpot · fabpot · commit 44f6a8c6b16b · 2017-01-09T12:23:12.000-08:00
This PR was merged into the 2.7 branch. Discussion ---------- [DI] Fix missing new line after private alias | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21219 (comment) | License | MIT | Doc PR | N/A Without this change, the output is: ```yml # [...] alias_for_foo: '@foo' another_alias_for_foo: alias: foo public: false another_third_alias_for_foo: '@foo' # <--- missing new line after `public: false` ``` (this is tested by the `CrossCheckTest` but there is no fixture file to update (automatically dumped and removed by the test case)) Commits ------- 101a165 [DI] Fix missing new line after private alias
diff --git a/src/Symfony/Component/DependencyInjection/Dumper/YamlDumper.php b/src/Symfony/Component/DependencyInjection/Dumper/YamlDumper.php
@@ -165,7 +165,7 @@ private function addServiceAlias($alias, $id)
             return sprintf("    %s: '@%s'\n", $alias, $id);
         }
 
-        return sprintf("    %s:\n        alias: %s\n        public: false", $alias, $id);
+        return sprintf("    %s:\n        alias: %s\n        public: false\n", $alias, $id);
     }
 
     /**
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/yaml/services6.yml b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/yaml/services6.yml
@@ -23,6 +23,8 @@ services:
     another_alias_for_foo:
         alias: foo
         public: false
+    another_third_alias_for_foo:
+        alias: foo
     decorator_service:
         decorates: decorated
     decorator_service_with_name:

Original file line number	Diff line number	Diff line change
`@@ -165,7 +165,7 @@ private function addServiceAlias($alias, $id)`
`165`	`165`	`return sprintf(" %s: '@%s'\n", $alias, $id);`
`166`	`166`	`}`
`167`	`167`
`168`		`- return sprintf(" %s:\n alias: %s\n public: false", $alias, $id);`
	`168`	`+ return sprintf(" %s:\n alias: %s\n public: false\n", $alias, $id);`
`169`	`169`	`}`
`170`	`170`
`171`	`171`	`/**`