bug #21639 [DI] Set getter edges as lazy (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 444b37d57554 · 2017-02-17T07:19:49.000+01:00
This PR was merged into the 3.3-dev branch.

Discussion
----------

[DI] Set getter edges as lazy

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Fixes tests

Commits
-------

279f6a2 [DI] Set getter edges as lazy
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/AnalyzeServiceReferencesPass.php b/src/Symfony/Component/DependencyInjection/Compiler/AnalyzeServiceReferencesPass.php
@@ -104,11 +104,16 @@ protected function processValue($value, $isRoot = false)
         }
         $this->lazy = false;
 
-        if ($this->onlyConstructorArguments) {
-            $this->processValue($value->getFactory());
-            $this->processValue($value->getArguments());
-        } else {
-            parent::processValue($value, $isRoot);
+        $this->processValue($value->getFactory());
+        $this->processValue($value->getArguments());
+
+        if (!$this->onlyConstructorArguments) {
+            $this->processValue($value->getProperties());
+            $this->lazy = true;
+            $this->processValue($value->getOverriddenGetters());
+            $this->lazy = false;
+            $this->processValue($value->getMethodCalls());
+            $this->processValue($value->getConfigurator());
         }
         $this->lazy = $lazy;
 
