Fix for race condition in console output stream write

rudolfratusinski · rudolfratusinski · commit 428dea6fb1d0 · 2018-10-11T17:13:12.000+08:00
diff --git a/src/Symfony/Component/Console/Output/StreamOutput.php b/src/Symfony/Component/Console/Output/StreamOutput.php
@@ -70,7 +70,11 @@ public function getStream()
      */
     protected function doWrite($message, $newline)
     {
-        if (false === @fwrite($this->stream, $message) || ($newline && (false === @fwrite($this->stream, PHP_EOL)))) {
+        if ($newline) {
+            $message .= PHP_EOL;
+        }
+
+        if (false === @fwrite($this->stream, $message)) {
             // should never happen
             throw new RuntimeException('Unable to write output.');
         }

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,11 @@ public function getStream()`
`70`	`70`	`*/`
`71`	`71`	`protected function doWrite($message, $newline)`
`72`	`72`	`{`
`73`		`- if (false === @fwrite($this->stream, $message) \|\| ($newline && (false === @fwrite($this->stream, PHP_EOL)))) {`
	`73`	`+ if ($newline) {`
	`74`	`+ $message .= PHP_EOL;`
	`75`	`+ }`
	`76`	`+`
	`77`	`+ if (false === @fwrite($this->stream, $message)) {`
`74`	`78`	`// should never happen`
`75`	`79`	`throw new RuntimeException('Unable to write output.');`
`76`	`80`	`}`