[CssSelector] Added cache on top of CssSelectorConverter

lyrixx · lyrixx · commit 40318763b10f · 2020-01-22T11:25:38.000+01:00
diff --git a/src/Symfony/Component/CssSelector/CssSelectorConverter.php b/src/Symfony/Component/CssSelector/CssSelectorConverter.php
@@ -27,15 +27,20 @@
 class CssSelectorConverter
 {
     private $translator;
+    private $html;
+
+    private static $xmlCache = [];
+    private static $htmlCache = [];
 
     /**
      * @param bool $html Whether HTML support should be enabled. Disable it for XML documents
      */
     public function __construct(bool $html = true)
     {
         $this->translator = new Translator();
+        $this->html = $html;
 
-        if ($html) {
+        if ($this->html) {
             $this->translator->registerExtension(new HtmlExtension($this->translator));
         }
 
@@ -57,6 +62,18 @@ public function __construct(bool $html = true)
      */
     public function toXPath(string $cssExpr, string $prefix = 'descendant-or-self::')
     {
-        return $this->translator->cssToXPath($cssExpr, $prefix);
+        if ($this->html) {
+            if (self::$htmlCache[$prefix][$cssExpr] ?? false) {
+                return self::$htmlCache[$prefix][$cssExpr];
+            }
+
+            return self::$htmlCache[$prefix][$cssExpr] = $this->translator->cssToXPath($cssExpr, $prefix);
+        }
+
+        if (self::$xmlCache[$prefix][$cssExpr] ?? false) {
+            return self::$xmlCache[$prefix][$cssExpr];
+        }
+
+        return self::$xmlCache[$prefix][$cssExpr] = $this->translator->cssToXPath($cssExpr, $prefix);
     }
 }
