bug #39839 [Messenger] [AmazonSqs] Fix auto-setup for fifo queue (starred-gijs)

nicolas-grekas · nicolas-grekas · commit 402a80097165 · 2021-01-15T11:12:41.000+01:00
This PR was submitted for the 5.x branch but it was merged into the 5.1 branch instead. Discussion ---------- [Messenger] [AmazonSqs] Fix auto-setup for fifo queue | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #39837 | License | MIT When you want the AmazonSqs transport to create the queue on the fly and you have a fifo queue, the parameters are wrong, and a regular queue is created. This PR fixes the parameters. Commits ------- 308f8fe [Messenger][AmazonSqs] Fix auto-setup for fifo queue
diff --git a/src/Symfony/Component/Messenger/Bridge/AmazonSqs/Transport/Connection.php b/src/Symfony/Component/Messenger/Bridge/AmazonSqs/Transport/Connection.php
@@ -258,7 +258,9 @@ public function setup(): void
         $parameters = ['QueueName' => $this->configuration['queue_name']];
 
         if (self::isFifoQueue($this->configuration['queue_name'])) {
-            $parameters['FifoQueue'] = true;
+            $parameters['Attributes'] = [
+                'FifoQueue' => 'true',
+            ];
         }
 
         $this->client->createQueue($parameters);

Original file line number	Diff line number	Diff line change
`@@ -258,7 +258,9 @@ public function setup(): void`
`25 6F50 8`	`258`	`$parameters = ['QueueName' => $this->configuration['queue_name']];`
`259`	`259`
`260`	`260`	`if (self::isFifoQueue($this->configuration['queue_name'])) {`
`261`		`- $parameters['FifoQueue'] = true;`
	`261`	`+ $parameters['Attributes'] = [`
	`262`	`+ 'FifoQueue' => 'true',`
	`263`	`+ ];`
`262`	`264`	`}`
`263`	`265`
`264`	`266`	`$this->client->createQueue($parameters);`