bug #32806 [Console] fix warning on PHP 7.4 (rez1dent3)

nicolas-grekas · nicolas-grekas · commit 3f431860c699 · 2019-07-30T19:22:34.000+02:00
This PR was submitted for the 4.3 branch but it was squashed and merged into the 3.4 branch instead (closes #32806). Discussion ---------- [Console] fix warning on PHP 7.4 | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT In php 7.4rc, accessing an array by key, sometimes causes an error. Rarely this error occurs on php 7.2. ```bash ErrorException: Trying to access array offset on value of type int /app/vendor/symfony/console/Input/ArrayInput.php:135 /app/vendor/symfony/console/Input/Input.php:55 /app/vendor/symfony/console/Application.php:208 /app/vendor/symfony/console/Application.php:149 /app/vendor/laravel/framework/src/Illuminate/Console/Application.php:90 /app/vendor/laravel/framework/src/Illuminate/Console/Application.php:182 /app/vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php:275 /app/vendor/laravel/framework/src/Illuminate/Foundation/Testing/PendingCommand.php:136 /app/vendor/orchestra/testbench-core/src/Database/MigrateProcessor.php:73 /app/vendor/orchestra/testbench-core/src/Database/MigrateProcessor.php:44 /app/vendor/orchestra/testbench-core/src/Concerns/WithLoadMigrationsFrom.php:27 ``` Commits ------- 5f451e6 [Console] fix warning on PHP 7.4
diff --git a/src/Symfony/Component/Console/Input/ArrayInput.php b/src/Symfony/Component/Console/Input/ArrayInput.php
@@ -132,7 +132,7 @@ protected function parse()
             }
             if (0 === strpos($key, '--')) {
                 $this->addLongOption(substr($key, 2), $value);
-            } elseif ('-' === $key[0]) {
+            } elseif (0 === strpos($key, '-')) {
                 $this->addShortOption(substr($key, 1), $value);
             } else {
                 $this->addArgument($key, $value);

Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,7 @@ protected function parse()`
`132`	`132`	`}`
`133`	`133`	`if (0 === strpos($key, '--')) {`
`134`	`134`	`$this->addLongOption(substr($key, 2), $value);`
`135`		`- } elseif ('-' === $key[0]) {`
	`135`	`+ } elseif (0 === strpos($key, '-')) {`
`136`	`136`	`$this->addShortOption(substr($key, 1), $value);`
`137`	`137`	`} else {`
`138`	`138`	`$this->addArgument($key, $value);`