bug #45414 [FrameworkBundle] KernelTestCase resets internal state on tearDown (core23)

nicolas-grekas · nicolas-grekas · commit 3e9a6e3a124c · 2022-02-18T10:47:49.000+01:00
This PR was submitted for the 6.1 branch but it was merged into the 4.4 branch instead. Discussion ---------- [FrameworkBundle] KernelTestCase resets internal state on tearDown | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | When using the `KernelTestCase` for multiple different test kernels, the `KernelTestCase::$class` is not reseted after the test has finished. All other class variables are set to the initial state, so this change should be a bugfix. Commits ------- a18c510 KernelTestCase resets internal state on tearDown
diff --git a/src/Symfony/Bundle/FrameworkBundle/Test/KernelTestCase.php b/src/Symfony/Bundle/FrameworkBundle/Test/KernelTestCase.php
@@ -44,6 +44,7 @@ abstract class KernelTestCase extends TestCase
     private function doTearDown()
     {
         static::ensureKernelShutdown();
+        static::$class = null;
         static::$kernel = null;
         static::$booted = false;
     }
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/TestServiceContainerTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/TestServiceContainerTest.php
@@ -44,4 +44,22 @@ public function testThatPrivateServicesAreAvailableIfTestConfigIsEnabled()
         $this->assertTrue(static::$container->has('private_service'));
         $this->assertFalse(static::$container->has(UnusedPrivateService::class));
     }
+
+    /**
+     * @doesNotPerformAssertions
+     */
+    public function testBootKernel()
+    {
+        static::bootKernel(['test_case' => 'TestServiceContainer']);
+    }
+
+    /**
+     * @depends testBootKernel
+     */
+    public function testKernelIsNotInitialized()
+    {
+        self::assertNull(self::$class);
+        self::assertNull(self::$kernel);
+        self::assertFalse(self::$booted);
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,7 @@ abstract class KernelTestCase extends TestCase`
`44`	`44`	`private function doTearDown()`
`45`	`45`	`{`
`46`	`46`	`static::ensureKernelShutdown();`
	`47`	`+ static::$class = null;`
`47`	`48`	`static::$kernel = null;`
`48`	`49`	`static::$booted = false;`
`49`	`50`	`}`