bug #29619 [Console] OutputFormatter: move strtolower to createStyleFromString (ogizanagi)

nicolas-grekas · nicolas-grekas · commit 3d33e71bd596 · 2018-12-17T11:05:51.000+01:00
This PR was merged into the 3.4 branch. Discussion ---------- [Console] OutputFormatter: move strtolower to createStyleFromString | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | not really | New feature? | no  | BC breaks? | no  | Deprecations? | no  | Tests pass? | yes  | Fixed tickets | N/A  | License | MIT | Doc PR | N/A While playing with the href feature that'll be available in 4.3, I spotted href value [is lowercased](#29620). Which I guess could be an issue on case-sensitive filesystems. This changes nothing for the current branch, but will allow when merging to upper branches to fix the behavior described above, hence keep original case. Commits ------- 8e2bd35 [Console] OutputFormatter: move strtolower to createStyleFromString
diff --git a/src/Symfony/Component/Console/Formatter/OutputFormatter.php b/src/Symfony/Component/Console/Formatter/OutputFormatter.php
@@ -157,7 +157,7 @@ public function format($message)
             if (!$open && !$tag) {
                 // </>
                 $this->styleStack->pop();
-            } elseif (false === $style = $this->createStyleFromString(strtolower($tag))) {
+            } elseif (false === $style = $this->createStyleFromString($tag)) {
                 $output .= $this->applyCurrentStyle($text);
             } elseif ($open) {
                 $this->styleStack->push($style);
@@ -203,13 +203,14 @@ private function createStyleFromString($string)
         $style = new OutputFormatterStyle();
         foreach ($matches as $match) {
             array_shift($match);
+            $match[0] = strtolower($match[0]);
 
             if ('fg' == $match[0]) {
-                $style->setForeground($match[1]);
+                $style->setForeground(strtolower($match[1]));
             } elseif ('bg' == $match[0]) {
-                $style->setBackground($match[1]);
+                $style->setBackground(strtolower($match[1]));
             } elseif ('options' === $match[0]) {
-                preg_match_all('([^,;]+)', $match[1], $options);
+                preg_match_all('([^,;]+)', strtolower($match[1]), $options);
                 $options = array_shift($options);
                 foreach ($options as $option) {
                     try {
