bug #34533 [Monolog Bridge] Fixed accessing static property as non static. (Sander-Toonen)

fabpot · fabpot · commit 3bd5faeaf6e0 · 2019-11-24T19:38:49.000+01:00
This PR was submitted for the 4.4 branch but it was merged into the 3.4 branch instead (closes #34533). Discussion ---------- [Monolog Bridge] Fixed accessing static property as non static. | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34505 | License | MIT | Doc PR | N/A Commits ------- aa045d1 [Monolog Bridge] Fixed accessing static property as non static.
diff --git a/src/Symfony/Bridge/Monolog/Handler/ChromePhpHandler.php b/src/Symfony/Bridge/Monolog/Handler/ChromePhpHandler.php
@@ -39,7 +39,7 @@ public function onKernelResponse(FilterResponseEvent $event)
         }
 
         if (!preg_match(static::USER_AGENT_REGEX, $event->getRequest()->headers->get('User-Agent'))) {
-            $this->sendHeaders = false;
+            self::$sendHeaders = false;
             $this->headers = [];
 
             return;
@@ -57,7 +57,7 @@ public function onKernelResponse(FilterResponseEvent $event)
      */
     protected function sendHeader($header, $content)
     {
-        if (!$this->sendHeaders) {
+        if (!self::$sendHeaders) {
             return;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ public function onKernelResponse(FilterResponseEvent $event)`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`if (!preg_match(static::USER_AGENT_REGEX, $event->getRequest()->headers->get('User-Agent'))) {`
`42`		`- $this->sendHeaders = false;`
	`42`	`+ self::$sendHeaders = false;`
`43`	`43`	`$this->headers = [];`
`44`	`44`
`45`	`45`	`return;`
`@@ -57,7 +57,7 @@ public function onKernelResponse(FilterResponseEvent $event)`
`57`	`57`	`*/`
`58`	`58`	`protected function sendHeader($header, $content)`
`59`	`59`	`{`
`60`		`- if (!$this->sendHeaders) {`
	`60`	`+ if (!self::$sendHeaders) {`
`61`	`61`	`return;`
`62`	`62`	`}`
`63`	`63`