minor #36137 [HttpClient] Issue notice when NativeHttpClient is used (trowski)

nicolas-grekas · nicolas-grekas · commit 3afe19801885 · 2020-03-23T12:34:24.000+01:00
This PR was merged into the 5.1-dev branch. Discussion ---------- [HttpClient] Issue notice when NativeHttpClient is used | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Simple PR to issue a notice to notify the user that `ext-curl` or `amphp/http-client` should be installed to use an HTTP/2 capable HTTP client. Not sure on the notice wording. Commits ------- 874c1e6 [HttpClient] Issue notice when NativeHttpClient is used
diff --git a/src/Symfony/Component/HttpClient/HttpClient.php b/src/Symfony/Component/HttpClient/HttpClient.php
@@ -61,6 +61,8 @@ public static function create(array $defaultOptions = [], int $maxHostConnection
             return new AmpHttpClient($defaultOptions, null, $maxHostConnections, $maxPendingPushes);
         }
 
+        @trigger_error((\extension_loaded('curl') ? 'Upgrade' : 'Install').' the curl extension or run "composer require amphp/http-client" to perform async HTTP operations, including full HTTP/2 support', E_USER_NOTICE);
+
         return new NativeHttpClient($defaultOptions, $maxHostConnections);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -61,6 +61,8 @@ public static function create(array $defaultOptions = [], int $maxHostConnection`
`61`	`61`	`return new AmpHttpClient($defaultOptions, null, $maxHostConnections, $maxPendingPushes);`
`62`	`62`	`}`
`63`	`63`
	`64`	`+ @trigger_error((\extension_loaded('curl') ? 'Upgrade' : 'Install').' the curl extension or run "composer require amphp/http-client" to perform async HTTP operations, including full HTTP/2 support', E_USER_NOTICE);`
	`65`	`+`
`64`	`66`	`return new NativeHttpClient($defaultOptions, $maxHostConnections);`
`65`	`67`	`}`
`66`	`68`