minor #28529 [Yaml] Skip parser test with root user (lbassin)

nicolas-grekas · nicolas-grekas · commit 3ad232835d4d · 2018-09-24T10:15:51.000+02:00
This PR was squashed before being merged into the 3.4 branch (closes #28529). Discussion ---------- [Yaml] Skip parser test with root user | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28478 | License | MIT | Doc PR | - This PR fix a test failure in YAML Component when running from a php docker container. By defaut, root user is used to run phpunit. It means permission checking will fail (Root user is always allowed to read files) Commits ------- 3442979 [Yaml] Skip parser test with root user
diff --git a/src/Symfony/Component/Yaml/Tests/ParserTest.php b/src/Symfony/Component/Yaml/Tests/ParserTest.php
@@ -2099,6 +2099,10 @@ public function testParsingNotReadableFilesThrowsException()
             $this->markTestSkipped('chmod is not supported on Windows');
         }
 
+        if (!getenv('USER') || 'root' === getenv('USER')) {
+            $this->markTestSkipped('This test will fail if run under superuser');
+        }
+
         $file = __DIR__.'/Fixtures/not_readable.yml';
         chmod($file, 0200);
 

Original file line number	Diff line number	Diff line change
`@@ -2099,6 +2099,10 @@ public function testParsingNotReadableFilesThrowsException()`
`2099`	`2099`	`$this->markTestSkipped('chmod is not supported on Windows');`
`2100`	`2100`	`}`
`2101`	`2101`
	`2102`	`+ if (!getenv('USER') \|\| 'root' === getenv('USER')) {`
	`2103`	`+ $this->markTestSkipped('This test will fail if run under superuser');`
	`2104`	`+ }`
	`2105`	`+`
`2102`	`2106`	`$file = __DIR__.'/Fixtures/not_readable.yml';`
`2103`	`2107`	`chmod($file, 0200);`
`2104`	`2108`